Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

do not block accepting connections #81

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

do not block accepting connections #81

wants to merge 1 commit into from

Commits on Oct 26, 2021

  1. do not block accepting connections 

    When using a plain TCP listener, goScanConnection creates some data
structures and moves on to scan which is wrapped in a goroutine.

When using a TLS listener, goScanConnection does not return until the
TLS handshake is complete. A lot can go wrong during this stage.

This change wraps goScanConnection in a goroutine to avoid blocking
accepting the next connection.
    @munkyboy
    munkyboy committed Oct 26, 2021
    Configuration menu
    Copy the full SHA
    2ee09f4 View commit details
    Browse the repository at this point in the history