Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correctly forward errors that not derived from Error #145

Merged
merged 2 commits into from
Jun 25, 2018
Merged

Correctly forward errors that not derived from Error #145

merged 2 commits into from
Jun 25, 2018

Conversation

IvanGoncharov
Copy link
Contributor

When Emscripten can't allocate memory it throws string with the error message but viz.js expects that Emscripten always throws objects derived from Error.
I also add test script so it's easier to do local testing during development.

@mdaines mdaines merged commit 483825d into mdaines:master Jun 25, 2018
@mdaines
Copy link
Owner

mdaines commented Jun 25, 2018

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants