Add support for -n cli option #151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! This looks like it should work. To build Viz.js, you should install the Emscripten SDK, Node, and Yarn. Please open an issue if it still fails so I can fix the instructions in the README. If you do get it to build, can you add a unit test? It may be difficult to test for the actual output, but you might test that different values of |
|
I added a unit test but only tested the results using neato (the program) since the build still fails for me. I'll open an issue if I can't get it to build. |
|
The tests pass on my machine. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix #150. I couldn't test it since building viz.js fails for me. Is there a complete list of the required libraries?