use a lookup table for str::upper() and str::lower() #760

JDanielSmith · 2023-12-06T15:04:47Z

A naive implementation of str::upper()/str::lower() can be slow because the C run-time might have to deal with locales. Since we only care about ASCII, a lookup table doesn't use much memory and is very fast.

…inux

…ncoding

…String itsefl)

…stead

…the work there

…f .str()

…zation

…to develop/format

Dan Smith and others added 30 commits January 17, 2022 12:10

throwing an exception makes walking a UTF-8 encoding easier

cd75ab9

can't compare Wndows1252 on Linux

bdcf34d

fixed another instance of trying to output a Windows-1252 string on L…

e1d4e9d

…inux

Merge branch 'master' into feature/encoded-string

bc1abcd

to_u8string() -> u8string() ala std::filesystem::path

6221045

begin simplifying Encoding.cpp

841bd3e

further simplify Encoding.h

6b396d2

to_w1252string() and to_native() to complement to_u8string()

17eee0d

can now consistently call details::to_XXX routines

cf20362

remove toNative(), str::toString() can use to_native()

b4da56b

use to_u8string instead of utf16to8

995df6b

more use of to_u8string() routines; consolidate conversion logic in E…

2c810fc

…ncoding

avoid an extra copy

a62cf7f

use str::EncodedStringView to mange XML

68cab5e

add an EncodedString that that stores the encoding of the string

f871b80

fixed unit-test that was sometimes failing on Windows

cde1c59

overloads for std::u16string and std::u8string

af6fd46

open up just one hole in EncodedStringView, not two

e5a6ebb

put w1252string() in details:: too

f193cc0

provide a "PlatformEncoding" value

3d22082

fix broken EncodedString

9e048d0

use EncodedString to better indicate our intentions (and test Encoded…

b91fd19

…String itsefl)

"struct details" is a bit goofy, use the normal "friend" mechanism in…

04a522e

…stead

since EncodedString is now a friend of EncodedStringView, just to do …

b46cffc

…the work there

Merge branch 'master' into feature/encoded-string

93b5322

gsl::narrow instead of static_cast

69e3358

Merge branch 'master' into feature/encoded-string

5668ce2

begin work on UTF-16/UTF-32 conversions

883d147

prepare to use EncodedString

020a568

older C++ compilers don't like so much "constexpr"

06c2c02

Dan Smith added 28 commits November 7, 2023 11:49

reduce use of .c_str()

79c1ff6

Context overload to take std::ostringstream directly minimizing use o…

3342e22

…f .str()

default arg needed for existing SWIG bindings

c2d418b

Merge branch 'main' into develop/format

c78a0cc

std::ostringstream overloads

34739bf

Merge branch 'main' into develop/format

58576b5

overloads for str::toString() to match std::to_string()

e7efd3c

str::toString() -> std::to_string()

c18ec83

Merge branch 'main' into develop/format

ca01b9f

Merge branch 'main' into develop/format

61430cb

return type needs to be explicit (not auto) for subsequent speciali…

0bd1dca

…zation

simplify toType<bool>()

9206153

Merge branch 'main' into develop/format

df7e652

use str::eq() instead of str::lower()

7ae633a

use a lookup table to quickly implement lower() and upper()

0671094

don't need ascii_toupper(), test W-1252 on Windows

f11f98f

don't need ascii_toupper(), test W-1252 on Windows

ded0d54

Merge branch 'develop/format' of https://github.com/mdaus/coda-oss in…

328dc85

…to develop/format

hookup up SLOW upper/lower for UTF-8

6ab5879

missed a few letters

2d6b8a0

Merge branch 'main' into feature/encoded-string

344d8dc

no w1252_lower(), etc.

c8ab7f4

Merge branch 'develop/string-Manip' into feature/encoded-string

27328d0

only upper/lower-case ASCII

62f8895

replace the transform upper()/lower() with the lookup table

2b54bdc

use char32_t so that values an be seen in the debugger

3c5844d

test to_w1252_upper() and to_w1252_lower()

e293629

use str::upper() and str::lower() overloads to reduce noise

f1c09ca

JDanielSmith self-assigned this Dec 6, 2023

JDanielSmith merged commit a869c8a into main Dec 6, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

use a lookup table for str::upper() and str::lower() #760

use a lookup table for str::upper() and str::lower() #760

JDanielSmith commented Dec 6, 2023

use a lookup table for str::upper() and str::lower() #760

use a lookup table for str::upper() and str::lower() #760

Conversation

JDanielSmith commented Dec 6, 2023