Moved the variable declarations to the top of functions #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@JonathanMeans FYI |
asylvest
added a commit
that referenced
this pull request
Jan 11, 2016
Moved the variable declarations to the top of functions
Closed
gpotts
pushed a commit
to gpotts/nitro
that referenced
this pull request
Jan 7, 2022
d372600 Merge pull request mdaus#7 from mdaus/gitSomeCpp11 07e9357 Put the subprocess call in a try/except block d304c17 Merge pull request mdaus#6 from mdaus/jenkins-config b46a67d Slight goof we missed: added a compiler check 6bcbb16 Merge pull request mdaus#5 from mdaus/math.linear_additions_up 799da60 Merge pull request mdaus#4 from mdaus/gitSomeCpp11 22762fc Update build.py c4a4a9d Update makeInstallPath.py f6a1026 Update jenkins.py 5c95bf8 Update VectorN.h edf3107 Update Matrix2D.h 8abde41 Update TwoD.h 392de9c Update OneD.hpp 7703bc1 Update OneD.h e4dae51 Update VectorN.h 879aa97 Update VectorN.h 0f05c32 Update Vector.h 03ad142 Update MatrixMxN.h 19910f9 Update Matrix2D.h 382b570 Removed SVN and GIT conditionals that were breaking build 7e4114d Removed SVN and GIT conditionals that were breaking build ce81510 Addressing comments: should be gxxCompileFlags.split() cedc26a Merge pull request mdaus#3 from mdaus/jenkins_config 675d8ff Update makeInstallPath.py 34f9ad5 Update makeInstallPath.py b89a567 Update jenkins.py b1503a3 Reverted branch testing changes, Reverted reversion of math.poly and math.linear python bindings due to git weirdness 8e09f95 Let's not break anything this time 8d7cde0 Let's not break anything this time 0be4856 Merge branch 'Branch_for_testing_merges' 6225849 2 Master: CHanged License 6af3867 1 Branch: Made a change to Branch_for_testing_merges 8cab082 Made a change` 7036f42 Revert "Merge branch 'master' of http://github.com/mdaus/coda-oss" 13ebf84 Merge branch 'master' of http://github.com/mdaus/coda-oss 4fcb193 Update VectorN.h 5f358e2 Update VectorN.h 6dc1e15 Update makeInstallPath.py 2513a53 Reverting out C++11 check completely for now as some other stuff got lost along the way when the merge was completed 7d22a80 Commenting out C++11 check as it is broken on Ubuntu f1681f6 @jakedebolt wins the intern-of-the-year award 5b5ce5e merge 96a0900 Updated with changes from code review d226171 Update makeInstallPath.py 5008140 Update jenkins.py bd54d43 Update jenkins.py 3340b24 Update jenkins.py 35377a4 Testing out shortened GIT_COMMIT id c4e0e5c SVN tag to GIT_COMMIT tag b3b8841 Added python bindings for Fit.h functions, math::linear::Vector<double>, and math::linear::Matrix2D<double>. 4c09e89 Reverting OneD.hpp back to original ebf3110 Reverting back to original OneD.h 3cc53ed Update OneD.hpp 64f153a Update OneD.h 278eff0 Update makeInstallPath.py 43281f1 Comments 9353516 Adding comments about another way to consider doing this down the road 4bab38f Changed Python bindings so they go to a single directory instead of a per-module directory 76c5fd3 Fixed typos in swig_linkage comments 6853bb2 Merge branch 'soname_crossplatform' 2b4efe6 Removing debugging pdb 6ca2847 Update jenkins.py cda577d Update jenkins.py af515a1 Added options to avoid explicit '.so' in windows in swig linkage, as well as some checks for the unsupported '-Wl,[opt]' in solaris studio 394feb8 Refactoring gcc version check 9e7eb6b added c++11 support checking, gcc version checking ad69c51 Modified build.py to handle crossplatform lib extensions f4764aa Adding waf list and waf msvs so we catch when/if these break 9f7df25 Adding types and sio.lite to CODA-OSS e231c1c Updating Swig bindings using Swig 3.0 13cdb26 Fixing Waf MSVS solution generator 577d12a Updated dumping operations based on tests 1be1f44 Revert "Revert "Moving python exception interface to except.i"" b8adace Merge branch 'swig_python_broken' e2de547 fixed indentation in build.py 0c9aa77 regenerated logging-python bindings 3c1e3da Re-added python check when processing a swig module 2b25a44 Revert "Moving python exception interface to except.i" 22524d6 Moving python exception interface to except.i 36478c0 Modified sys-python to prevent name collision 08b7cc4 Added sys swig bindings 6c52ba4 Regenerated some bindings 915a70c Enhancments to build system to improve dependency handling + coda_* includes 5a29021 Removed extraneous src_prefix from except 1ed3a11 Fixed %import capability, rewrote swigInclude code 48f1e9d Added except-python de461ba Modifications to support true python modules a62401d testing coda_* python modules with directories renamed to just *, but keeping modules named coda_* 7b90602 Improving test to test printing, getting, and setting for 1D and 2D 9bde847 Fixing formatting. Adding __str()__ method for printing 7113d44 Improving get/set methods for 1D and 2D polynomials. Patch provided by Marc Trachy from Valkyrie. git-subtree-dir: externals/coda-oss git-subtree-split: d372600
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MSVC 11.0 still requires the variables to be the first thing in C functions.