Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Travis CI with GitHub Actions (for v3) #759

Closed
wants to merge 5 commits into from

Conversation

phanect
Copy link
Contributor

@phanect phanect commented May 9, 2024

This PR removes Travis CI and adds GitHub Actions instead.
This PR is for EJS v3.x (main branch)

I created #758 to update Node.js versions on Travis CI to the currently supported versions (v18, v20, v22), but I noticed Travis CI is not working as expected because you need to contact Travis CI support to get free credits for OSS projects.
Since GitHub Actions is much more popular than Travis CI nowadays and easier to use for free, I suggest migrating to GitHub Actions.

If you prefer Travis CI, you can close this PR and consider merging #758 instead.

Support for Node.js v8, v10, and v12 are removed and replaced with v18, v20, v21, and v22.
This is not breaking change because `engine-strict` is not set in .npmrc and npm only warns if the user uses legacy Node.js versions.
@mde
Copy link
Owner

mde commented May 9, 2024

This looks great! Make sure you take a look at the version-4 branch. It should be landing soon. I am happy to use GH actions.

@mde
Copy link
Owner

mde commented May 9, 2024

The build process is a little more complicated. I'm happy to write a quick doc to explain how it will work in version 4.

@phanect
Copy link
Contributor Author

phanect commented May 9, 2024

@mde Thanks, then should this PR be merged to version-4 branch rather than main?

The build process is a little more complicated. I'm happy to write a quick doc to explain how it will work in version 4.

OK, thanks!

@phanect phanect changed the title Replace Travis CI with GitHub Actions Replace Travis CI with GitHub Actions (for v3) May 10, 2024
@phanect
Copy link
Contributor Author

phanect commented May 10, 2024

@mde I opened #760 for version-4 branch.
Should this PR (to the main branch) be closed or do you merge this PR?

@mde
Copy link
Owner

mde commented May 10, 2024

This work should probably merge against main after the version-4 branch lands. Sorry for the inconvenience.

@phanect
Copy link
Contributor Author

phanect commented May 10, 2024

@mde No problem, thanks!

However, the commits included in #760 are almost the same as this PR (and probably they conflict), so if you plan to merge this PR after version-4 branch is merged to main, I think this PR can be closed and #760 should be merged instead.

I'm closing this PR for now, but feel free to reopen this if I misunderstand something.
Please review #760 instead 🙇🏻‍♂️

@phanect phanect closed this May 10, 2024
@mde
Copy link
Owner

mde commented May 10, 2024

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants