Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FPS defaulting is problematic #9

Open
mdegans opened this issue Mar 24, 2021 · 0 comments
Open

FPS defaulting is problematic #9

mdegans opened this issue Mar 24, 2021 · 0 comments
Assignees
@mdegans
Labels
bug Something isn't working high priority

Comments

@mdegans
Copy link
Owner

mdegans commented Mar 24, 2021

The way the default frame rate is set is problematic.

const int DEFAULT_FPS = 21;       // mostly ignored, deprecated
const int DEFAULT_HEIGHT = 1080;  // mostly ignored, deprecated
const int DEFAULT_WIDTH = 1920;   // mostly ignored, deprecated

All need to go. This is bad design and inflexible when new sensors are used.

Proposed solution: default to camera mode 0
@mdegans mdegans mentioned this issue Sep 2, 2021
Open
@mdegans mdegans self-assigned this Sep 2, 2021
@mdegans mdegans added bug Something isn't working high priority labels Sep 2, 2021
mdegans added a commit that referenced this issue Sep 3, 2021
@mdegans
Sensor mode fixes
5fa5893 
* Sensor mode now defaults to 0 (best)
* Caps downstream have no effect on the sensor mode.
* Tests pass on NX now

Fixes #9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mdegans mdegans

Labels
bug Something isn't working high priority
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mdegans