Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cook 2.34 #13

Merged
merged 3 commits into from
Apr 7, 2018
Merged

Fix cook 2.34 #13

merged 3 commits into from
Apr 7, 2018

Conversation

shlomif
Copy link
Contributor

@shlomif shlomif commented Apr 2, 2018

Hi!

Thanks for maintaining cook. In this pull-req I fixed the "./configure && make && make test" build process. I'd like to tackle the task of adding https://en.wikipedia.org/wiki/Continuous_integration next (is Travis ok?). Note that while my opinions about the GNU autotools are not too kind (see http://www.shlomifish.org/open-source/anti/autohell/ ) I'm not sure if converting the bootstrapping build system to cmake or meson or whatever will be worth it here.

@mdhender mdhender changed the base branch from master to dev-cook.2.35 April 7, 2018 20:07
@mdhender
Copy link
Owner

mdhender commented Apr 7, 2018

Thanks. I'm merging this in to a new branch, dev-cook.2.35.

@mdhender mdhender merged commit 995aed9 into mdhender:dev-cook.2.35 Apr 7, 2018
@shlomif
Copy link
Contributor Author

shlomif commented Apr 7, 2018 via email

@shlomif shlomif mentioned this pull request Jun 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants