Use qtfaststart for relocating MOOV atoms #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… file for faster streaming.
|
Tried cloning my fork ... the submodules don't automatically come with it. You need to run Also see this - http://codingkilledthecat.wordpress.com/2012/04/28/why-your-company-shouldnt-use-git-submodules/ |
mdhiggins
added a commit
that referenced
this pull request
Feb 23, 2013
Use qtfaststart for relocating MOOV atoms
|
I'm getting an import error here trying to import qtfaststart |
|
Is your qtfaststart directory empty? Might have to run this:
Thinking submodules wasn't such a good idea... |
|
I can't seem to get this to work, after tweaking it to get it to not crash the converter file gets messed up too, are you having these issues as well? |
|
Works fine for me ... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request resolves issue #10 by including qtfaststart to relocate MOOV atoms. I added an additional setting in case users don't want to move it.
Qtfaststart is pulled in via a submodule, so please let me know if that works for you. It seems the downside of submodules is that you probably can't edit them. But I suppose you could always create your own fork and pull that in as a submodule. You can keep your fork up to date with upstream by adding the source repository as an additional remote. Read more about it here - https://help.github.com/articles/fork-a-repo but for now I can't see a reason we'd need to fork qtfaststart.