Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(dependency): update Prismjs #387

Merged
merged 1 commit into from
Jan 20, 2020
Merged

chore(dependency): update Prismjs #387

merged 1 commit into from
Jan 20, 2020

Conversation

schalkneethling
Copy link

Updates Prismjs to the latest v1.19.0

Fixes #386

Updates prismjs to the latest v1.19.0

Fixes #386
@peterbe
Copy link
Contributor

peterbe commented Jan 17, 2020

I'd rather use package.json instead. Similar to how we're doing with codemirror. Vendoring massive JS libs is soo 2007 :)

@peterbe
Copy link
Contributor

peterbe commented Jan 17, 2020

Oh I see. This is a custom build bundle of prism.js.

Copy link
Contributor

@peterbe peterbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You might want to consider reviewing the name of the destFileName on line 36 in bundles.json because I suspect that 1-8-4 might be an artifact from https://www.npmjs.com/package/prismjs/v/1.8.4
Truth is, it doesn't make sense to have prism.js dictate the name of the bundle because the bundle is also made up of other things such as clipboard.js.

Also, remember, these days we have a cache busting query string on the static assets injected in the final HTML. So perhaps it'd be better to just call it "destFileName": "css-examples-libs"

@peterbe
Copy link
Contributor

peterbe commented Jan 17, 2020

Note, if you do consider changing the destFileName you're going to need first merge in master into this branch.

@schalkneethling
Copy link
Author

🎉 This PR is included in version 1.1.47 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Prismjs
2 participants