Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct Safari support for background-clip #14030

Merged
merged 1 commit into from
Jan 26, 2022

Conversation

lukewarlow
Copy link
Contributor

Summary

This PR updates Safari support data for the background-clip property to show it's supported as of Safari 14.

Test results and supporting details

Based on issue it definitely wasn't supported before Safari 14. And definitely was from at least Safari 14.1.

I have verified it works on iOS 14.5 and Safari 15.2 personally.

Related issues

Fixes #13977

@github-actions github-actions bot added the data:css 🎨 Compat data for CSS features. https://developer.mozilla.org/docs/Web/CSS label Dec 15, 2021
@lukewarlow lukewarlow marked this pull request as ready for review December 15, 2021 17:34
@lukewarlow
Copy link
Contributor Author

I've looked but can't find any webkit commits to help confirm whether it was 14 or 14.1 that it was added in.

@ddbeck
Copy link
Collaborator

ddbeck commented Jan 18, 2022

@queengooborg do you know if there's an easy way to test 14 versus 14.1?

If not, I'm OK with merging as-is.

@queengooborg
Copy link
Collaborator

SauceLabs has both versions available, that's the easiest way I can think of?

@ddbeck
Copy link
Collaborator

ddbeck commented Jan 25, 2022

SauceLabs has both versions available, that's the easiest way I can think of?

@queengooborg wait, really? What combination of settings do I use to get that because it only showed me 14.1 when I checked (before asking for your input). If there's a trick to it, that would be great to know.

@queengooborg
Copy link
Collaborator

There's a little trick to it, yeah -- my apologies, I thought I wrote up how to do so but apparently not... Alas, I just found out this won't work for Safari 14 + 15, but I'll leave the trick here anyways:

In SauceLabs, when selecting Safari 10 through 13, the "OS Version" dropdown will include two different macOS versions. Simply select the older of the two, and you're good to go!

Copy link
Collaborator

@ddbeck ddbeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, since I can't directly test this to be sure it wasn't later, I'm going to merge it as written. Thank you, @lukewarlow! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:css 🎨 Compat data for CSS features. https://developer.mozilla.org/docs/Web/CSS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

css.properties.background-clip - supported unprefixed in Safari 14
3 participants