Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add data for html.elements.data.value #22093

Merged
merged 1 commit into from
Feb 5, 2024
Merged

Add data for html.elements.data.value #22093

merged 1 commit into from
Feb 5, 2024

Conversation

skyclouds2001
Copy link
Contributor

Summary

the data of html.elements.data.value is taken and reused from api.HTMLDataElement.value, since the two share the same test steps

Test results and supporting details

Related issues

@github-actions github-actions bot added the data:html 📄 Compat data for HTML elements. https://developer.mozilla.org/docs/Web/HTML label Jan 29, 2024
@skyclouds2001 skyclouds2001 marked this pull request as ready for review January 29, 2024 12:32
Elchi3
Elchi3 approved these changes Feb 5, 2024
View reviewed changes
Copy link
Member

@Elchi3 Elchi3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! 👍

@Elchi3 Elchi3 merged commit 0b72ed4 into mdn:main Feb 5, 2024
5 checks passed
@skyclouds2001 skyclouds2001 deleted the html.elements.data.value branch February 5, 2024 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Elchi3 Elchi3 Elchi3 approved these changes

Assignees
No one assigned
Labels
data:html 📄 Compat data for HTML elements. https://developer.mozilla.org/docs/Web/HTML
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@skyclouds2001 @Elchi3