Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added missing compatiblity information for Tab objects and related APIs #260

Merged
merged 1 commit into from
Jun 21, 2017
Merged

Conversation

snoack
Copy link
Contributor

@snoack snoack commented Jun 17, 2017

I added missing compatibility information for following API features:

  • Tab.width and Tab.height
    • Added in Chrome 31 according to their documentation (receptively Opera 18).
    • I checked on Firefox 53 and they exist, presumably they were added along basic support.
    • Not supported on Microsoft Edge according to their documentation.
  • Tab.audible
    • Added in Chrome 45 according to their documentation (respectively Opera 32).
    • I checked on Firefox 53 and it exists, presumably it was added along basic support.
    • Not supported on Microsoft Edge according to their documentation.
  • Tab.mutedInfo
    • Added in Chrome 46 according to their documentation (respectively Opera 33).
    • I checked on Firefox 53 and it exists, presumably it was added along basic support.
    • Not supported on Microsoft Edge according to their documentation.
  • Tab.openerTabId
    • Added in Chrome 18 according to their documentation (respectively Opera 15).
    • I didn't change the compatibility information for other browsers, but FWIW I confirmed that Firefox still does not support it, and it's still neither supported on Edge according to its documentation.
  • Tab.sessionId
    • Added in Chrome 31 according to their documentation (respectively Opera 18).
    • I checked on Firefox 53 and it does not exist there.
    • Since Microsoft Edge does not have the session API, I assume that it does not exist there either.
  • Tab.discarded and Tab.autoDiscardable
    • Added in Chrome 54 according to their documentation (respectively Opera 41).
    • I checked on Firefox 53 and they do not exist there.
    • Assuming that they do not exist on Microsoft Edge either, since it is a rather new feature.
  • tabs.create() options
    • openerTabId
      • (see above)
  • tabs.update() options
    • openerTabId, autoDiscardable
      • (see above)
    • muted
      • Added in Chrome 45 according to their documentation (respectively Opera 32).
      • I didn't change the compatibility information for other browsers.
  • tabs.query() options
    • audible, muted, discarded, autoDiscardable
      • (see above)
    • pinned
      • Supported in Chrome/Opera, exact version added is unknown.
      • I checked on Firefox 53 and it exists, presumably it was added along basic support.
      • Not supported on Microsoft Edge according to their documentation.
    • index
      • Added in Chrome 18 according to their documentation (respectively Opera 15).
      • I checked on Firefox 53 and it exists, presumably it was added along basic support.
      • Assuming that it exists on Microsoft Edge as well, since not indicated otherwise.
    • currentWindow and lastFocusedWindow
      • Added in Chrome 19 according to their documentation (respectively Opera 15).
      • I checked on Firefox 53 and they exist, presumably they were added along basic support.
      • Assuming that they exist on Microsoft Edge as well, since not indicated otherwise.

Other (apparent) changes in the patch are due to changing the order of the features within the API. As usual, I sorted them (for consistency) in the order they have been implemented.

@snoack
Copy link
Contributor Author

snoack commented Jun 17, 2017

I just added discarded and autoDiscardable to the Tab, tabs.update and tabs.query documentation pages. All other features this pull request adds compatibility information for were already documented.

@Elchi3 Elchi3 added the data:webext 🎲 Compat data for Browser Extensions. https://developer.mozilla.org/Add-ons/WebExtensions label Jun 17, 2017
@snoack
Copy link
Contributor Author

snoack commented Jun 19, 2017

Updated the pull request, in order to add a note to tabs.create about this Edge bug.

@snoack
Copy link
Contributor Author

snoack commented Jun 20, 2017

Rebased on top of #263. Please merge #263 first.

@snoack
Copy link
Contributor Author

snoack commented Jun 21, 2017

Rebased (on top of master).

Copy link
Collaborator

@wbamberg wbamberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice work, again.

The only thing I might say is that usually we would have one row for each subfeature, not one for "width, height". I guess your thinking is that these are so closely tied that it's better to have them together?

Anyway I don't think that should stop this from getting merged.

@wbamberg wbamberg merged commit 1cb9d2d into mdn:master Jun 21, 2017
@snoack
Copy link
Contributor Author

snoack commented Jun 21, 2017

Yeah, I remember having that discussion before, but it might be different here, as you said, width and height are very closely tied to each other. For reference, it's similar to the keyand values methods of the Map object which are indicated in a similar way. But I also wouldn't mind to change it.

@snoack snoack deleted the tabs branch September 15, 2017 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:webext 🎲 Compat data for Browser Extensions. https://developer.mozilla.org/Add-ons/WebExtensions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants