Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump minimum Node.js version to 8.0.0 #4034

Merged
merged 1 commit into from
May 2, 2019
Merged

Bump minimum Node.js version to 8.0.0 #4034

merged 1 commit into from
May 2, 2019

Conversation

queengooborg
Copy link
Collaborator

Fixes #3509. It's May 1st, a day after we said we'd raise the minimum Node.js version. So, here we are!

@queengooborg queengooborg added the infra 🏗️ Infrastructure issues (npm, GitHub Actions, releases) of this project label May 1, 2019
@queengooborg queengooborg requested a review from Elchi3 May 1, 2019 10:36
Elchi3
Elchi3 approved these changes May 2, 2019
View reviewed changes
Copy link
Member

@Elchi3 Elchi3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! 👍

@Elchi3 Elchi3 merged commit dff7857 into master May 2, 2019
@Elchi3 Elchi3 deleted the minimum-node-8 branch May 2, 2019 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Elchi3 Elchi3 Elchi3 approved these changes

Assignees
No one assigned
Labels
infra 🏗️ Infrastructure issues (npm, GitHub Actions, releases) of this project
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Raise minimum node version to 8 in April 30, 2019
2 participants
@queengooborg @Elchi3