Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more font- CSS properties #496

Merged
merged 11 commits into from
Oct 12, 2017
Merged

Conversation

ddbeck
Copy link
Collaborator

@ddbeck ddbeck commented Oct 10, 2017

This PR adds five more font- CSS properties:

"version_added": "7"
},
"safari_ios": {
"version_added": "4.1"
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm a little suspicious of this appearing on iOS so many versions before desktop, but then again I don't know how iOS and macOS version numbers line up, exactly.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree, I would set true.

"version_added": "7"
},
"opera_android": {
"version_added": "6"
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is another mobile-before-desktop case that I was suspicious of. Is it documented anywhere when the various mobile/desktop browsers get their version numbers synced up? I think Firefox, Chrome, and Opera do this at different versions, but I don't know when.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This discrepency is correct: see http://www.opera.com/docs/history/presto/ and Opera Mobile history on wikipedia.

These are the first releases supporting the Presto engine.

Copy link
Contributor

@teoli2003 teoli2003 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, that's very good. A few values to change, but nothing big.

"mdn_url": "https://developer.mozilla.org/docs/Web/CSS/font-language-override",
"support": {
"webview_android": {
"version_added": null
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"version_added": null
},
"chrome": {
"version_added": null
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

false

"version_added": null
},
"chrome_android": {
"version_added": null
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

false

"version_added": null
},
"edge": {
"version_added": null
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

false: no info at all about this around Edge, so this is a rather safe bet.

"version_added": null
},
"edge_mobile": {
"version_added": null
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

false

"version_added": false
},
"safari": {
"version_added": false
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"version_added": null
},
"edge": {
"version_added": true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

12

"version_added": "1"
},
"chrome_android": {
"version_added": null
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1

"version_added": true
},
"edge_mobile": {
"version_added": true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

12

"version_added": "7"
},
"opera_android": {
"version_added": "6"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This discrepency is correct: see http://www.opera.com/docs/history/presto/ and Opera Mobile history on wikipedia.

These are the first releases supporting the Presto engine.

Copy link
Collaborator Author

@ddbeck ddbeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, I think I've corrected everything unless otherwise mentioned. Thanks!

"version_added": "31",
"notes": [
"Before Firefox 57, animations using em units are not affected by changes to the <code>font-size</code> of the animated element's parent (<a href='https://bugzil.la/1254424'>bug 1254424</a>).",
"Before Firefox 57, some language settings' inherited <code>font-size</code> is smaller than expected (<a href='https://bugzil.la/1391341'>bug 1391341</a>)"
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I intended a plural possessive here (i.e. the inherited font-size of the language setting). Fixed a missing period though.

Also, now that I think about it, should these notes apply to the mobile Firefox as well?

Copy link
Contributor

@teoli2003 teoli2003 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, r+

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:css 🎨 Compat data for CSS features. https://developer.mozilla.org/docs/Web/CSS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants