Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken Link/Missing ARIA Guide for Managing Modal and Non-modal Dialogs #1437

Closed
1 of 2 tasks
chrisdavidmills opened this issue Jan 18, 2021 · 1 comment · Fixed by #3255
Closed
1 of 2 tasks

Broken Link/Missing ARIA Guide for Managing Modal and Non-modal Dialogs #1437

chrisdavidmills opened this issue Jan 18, 2021 · 1 comment · Fixed by #3255
Labels
Content:Accessibility Accessibility docs effort: small This task is a small effort. good first issue A good issue for newcomers to get started with. help wanted If you know something about this topic, we would love your help! p2 Minor issue with low priority, can be fixed later.

Comments

@chrisdavidmills
Copy link
Contributor

@clinejj commented on Mon Dec 21 2020

URL(s)

https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Roles/dialog_role
https://developer.mozilla.org/en-US/docs/ARIA/ARIA_Guides/Managing_Modal_and_Non_Modal_Dialogs

Request type

  • New documentation
  • Correction or update

Details

The link to "Managing Modal and Non Modal Dialogs" (https://developer.mozilla.org/en-US/docs/ARIA/ARIA_Guides/Managing_Modal_and_Non_Modal_Dialogs) leads to a 404. This guide appears to be referenced at the Guides Index (https://github.com/mdn/content/blob/main/files/en-us/web/accessibility/aria/aria_guides/index.html), but there are no links to any pages there.

Link is referenced at https://github.com/mdn/content/blob/main/files/en-us/web/accessibility/aria/roles/dialog_role/index.html#L57

Issue also filed previously at https://bugzilla.mozilla.org/show_bug.cgi?id=1482827

And apologies for the mis-label, there was not an issue type that referenced the accessibility pages.

@chrisdavidmills chrisdavidmills added effort: small This task is a small effort. Content:Accessibility Accessibility docs labels Jan 18, 2021
@chrisdavidmills chrisdavidmills added good first issue A good issue for newcomers to get started with. help wanted If you know something about this topic, we would love your help! p2 Minor issue with low priority, can be fixed later. labels Mar 15, 2021
@chrisdavidmills
Copy link
Contributor Author

To whoever fixes this issue, you need to remove the broken link from the site, or find another resource somewhere else that fulfills this role to link to.

chrisdavidmills pushed a commit that referenced this issue Mar 18, 2021
* Updated Typo

Fixes #2658

* Removed the link 

Fixes #1437
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Content:Accessibility Accessibility docs effort: small This task is a small effort. good first issue A good issue for newcomers to get started with. help wanted If you know something about this topic, we would love your help! p2 Minor issue with low priority, can be fixed later.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant