Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WebAPI-ReadableStreamDefaultReader/read] Correction #1453

Closed
1 of 3 tasks
chrisdavidmills opened this issue Jan 18, 2021 · 1 comment · Fixed by #2369
Closed
1 of 3 tasks

[WebAPI-ReadableStreamDefaultReader/read] Correction #1453

chrisdavidmills opened this issue Jan 18, 2021 · 1 comment · Fixed by #2369
Assignees
@Rumyra
Labels
Content:WebAPI Web API docs

Comments

@chrisdavidmills
Copy link
Contributor

@x2zh commented on Mon Nov 23 2020

Request type

  • Please close this issue, I accidentally submitted it without adding any details
  • New documentation
  • Correction or update

Details

Example 2 - handling text line by line
image

According to the spec https://encoding.spec.whatwg.org/#interface-textdecoder，
image
TextDecodeOptions.stream's default value is false. In order to process a fragmented input, the method, decode, should be invoked with options’s stream set to true
@chrisdavidmills chrisdavidmills mentioned this issue Jan 18, 2021
Closed
3 tasks
Rumyra added a commit that referenced this issue Feb 15, 2021
@Rumyra
Adding stream true option
427d2a0 
This fixes #1453
@Rumyra Rumyra mentioned this issue Feb 15, 2021
Merged
@Rumyra
Copy link
Collaborator

Rumyra commented Feb 15, 2021

PR to fix is here #2369

@Rumyra Rumyra self-assigned this Feb 15, 2021
sideshowbarker pushed a commit that referenced this issue Feb 16, 2021
@Rumyra
Add "stream: true" to ReadableStreamDefaultReader.p.read example (#2369)
c7c0244 
Fixes #1453
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 10, 2022
barhenthv added a commit to barhenthv/content that referenced this issue Aug 2, 2024
@barhenthv
Add "stream: true" to ReadableStreamDefaultReader.p.read example (#2369)
b394440 
Fixes mdn/content#1453
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Rumyra Rumyra

Labels
Content:WebAPI Web API docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add "stream: true" to ReadableStreamDefaultReader.p.read example mdn/content
2 participants
@chrisdavidmills @Rumyra