Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change history.pushstate|replacestate 2nd param name to “unused” #13322

Merged

Conversation

@sideshowbarker sideshowbarker requested a review from a team as a code owner February 27, 2022 21:41
@sideshowbarker sideshowbarker requested review from jpmedley and wbamberg and removed request for a team February 27, 2022 21:41
@github-actions github-actions bot added the Content:WebAPI Web API docs label Feb 27, 2022
@sideshowbarker sideshowbarker removed the request for review from jpmedley February 27, 2022 21:42
@github-actions
Copy link
Contributor

github-actions bot commented Feb 27, 2022

Preview URLs

Flaws

None! 🎉

External URLs

URL: /en-US/docs/Web/API/History/replaceState
Title: History.replaceState()
on GitHub

No new external URLs


URL: /en-US/docs/Web/API/History/pushState
Title: History.pushState()
on GitHub

No new external URLs

(this comment was updated 2022-02-28 06:32:45.991987)

@sideshowbarker sideshowbarker force-pushed the sideshowbarker/history-pushstate-replacestate-unused-param branch from e20e3b2 to e5455d8 Compare February 28, 2022 06:30
Copy link
Contributor

@teoli2003 teoli2003 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good to me!

@teoli2003 teoli2003 merged commit 575c163 into main Feb 28, 2022
@teoli2003 teoli2003 deleted the sideshowbarker/history-pushstate-replacestate-unused-param branch February 28, 2022 12:17
ddbeck pushed a commit to mdn/browser-compat-data that referenced this pull request Mar 10, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Content:WebAPI Web API docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Content bug: second parameter of history.pushState/replaceState has been renamed to unused
2 participants