Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nav requestmidi updates #13479

Merged
merged 2 commits into from
Mar 4, 2022
Merged

Conversation

hamishwillee
Copy link
Collaborator

This is part of web midi API updates for FF99.

  1. Adds secure context header to the Web MIDI API and Navigator.requestMIDIAccess() pages.
    • QUESTION - these are the only places the header required right? I.e. is present on MediaAccess but I don't think it should be?
  2. Tidies a few other bits comments inline.

@hamishwillee hamishwillee requested a review from a team as a code owner March 4, 2022 04:15
@hamishwillee hamishwillee requested review from Elchi3 and removed request for a team March 4, 2022 04:15
@github-actions github-actions bot added the Content:WebAPI Web API docs label Mar 4, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Mar 4, 2022

Preview URLs

Flaws

Note! 1 document with no flaws that don't need to be listed. 🎉

URL: /en-US/docs/Web/API/Navigator/requestMIDIAccess
Title: Navigator.requestMIDIAccess()
on GitHub
Flaw count: 1

  • broken_links:
    • Can't resolve https://developer.mozilla.org/en-US/docs/Web/API/Web_MIDI_API

External URLs

URL: /en-US/docs/Web/API/Navigator/requestMIDIAccess
Title: Navigator.requestMIDIAccess()
on GitHub

No new external URLs


URL: /en-US/docs/Web/API/Web_MIDI_API
Title: Web MIDI API
on GitHub

No new external URLs

@hamishwillee hamishwillee mentioned this pull request Mar 4, 2022
7 tasks
@Rumyra
Copy link
Collaborator

Rumyra commented Mar 4, 2022

This is great @hamishwillee thank you! I'm going to pep up the MIDI API landing page as part of this work - so can be more explicit there about some of the things mentioned above. And yes we just put secure context on interface pages now, rather than all member pages iirc. So there's probably that to look at as well 👍

@Rumyra Rumyra merged commit f47263d into mdn:main Mar 4, 2022
@hamishwillee hamishwillee deleted the nav_requestmidi_updates branch March 7, 2022 01:44
@hamishwillee
Copy link
Collaborator Author

Great! I think it makes sense to add the secure context tag to Navigator.requestMIDIAccess() as well as the interface top level page. Reason being is that this is where that access is gated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:WebAPI Web API docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants