Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix attribute name #17332

Merged
merged 1 commit into from
Jun 16, 2022
Merged

Fix attribute name #17332

merged 1 commit into from
Jun 16, 2022

Conversation

heyallan
Copy link
Contributor

Summary

Attribute name [data-text="..."] should match selector this.getAttribute('data-text')

Motivation

Otherwise attribute selector will return null and popup example will display empty popup

Supporting details

Demo with error: https://stackblitz.com/edit/js-kjvfq4?file=index.html

Metadata

  • Adds a new document
  • Rewrites (or significantly expands) a document
  • Fixes a typo, bug, or other error

@heyallan
Fix attribute name
259865c 
Attribute name `element[data-text="..."]` should match selector `this.getAttribute('data-text')`
@heyallan heyallan requested a review from a team as a code owner June 16, 2022 04:36
@heyallan heyallan requested review from sideshowbarker and removed request for a team June 16, 2022 04:36
@github-actions github-actions bot added the Content:WebAPI Web API docs label Jun 16, 2022
@github-actions
Copy link
Contributor

Preview URLs

Flaws

None! 🎉

External URLs

URL: /en-US/docs/Web/API/CustomElementRegistry/define
Title: CustomElementRegistry.define()
on GitHub

No new external URLs

teoli2003
teoli2003 approved these changes Jun 16, 2022
View reviewed changes
Copy link
Contributor

@teoli2003 teoli2003 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. Thank you!

@teoli2003 teoli2003 merged commit 269e6df into mdn:main Jun 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teoli2003 teoli2003 teoli2003 approved these changes

@sideshowbarker sideshowbarker Awaiting requested review from sideshowbarker sideshowbarker is a code owner automatically assigned from mdn/yari-content-web-api

Assignees
No one assigned
Labels
Content:WebAPI Web API docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@heyallan @teoli2003