Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Demix cancel event from GlobalEventHandlers #18115

Merged
merged 7 commits into from
Jul 10, 2022
Merged

Demix cancel event from GlobalEventHandlers #18115

merged 7 commits into from
Jul 10, 2022

Conversation

queengooborg
Copy link
Collaborator

This PR demixes the oncancel event handler from the GlobalEventHandlers mixin. Related BCD PR: mdn/browser-compat-data#16847

@queengooborg queengooborg requested review from a team as code owners July 8, 2022 08:06
@queengooborg queengooborg requested review from wbamberg and removed request for a team July 8, 2022 08:06
@github-actions github-actions bot added the Content:WebAPI Web API docs label Jul 8, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Jul 8, 2022 •
edited
Loading

Preview URLs

Flaws

Note! 1 document with no flaws that don't need to be listed. 🎉

URL: /en-US/docs/Web/API/GlobalEventHandlers
Title: GlobalEventHandlers
on GitHub
Flaw count: 40

  • macros:
    • /en-US/docs/Web/API/GlobalEventHandlers/onabort redirects to /en-US/docs/Web/API/HTMLMediaElement/abort_event
    • /en-US/docs/Web/API/GlobalEventHandlers/onpointerlockchange does not exist
    • /en-US/docs/Web/API/GlobalEventHandlers/onpointerlockerror does not exist
    • /en-US/docs/Web/API/GlobalEventHandlers/onprogress does not exist
    • /en-US/docs/Web/API/GlobalEventHandlers/onratechange does not exist
    • and 10 more flaws omitted
  • bad_bcd_links:
    • no explanation!
    • no explanation!
    • no explanation!
    • no explanation!
    • no explanation!
    • and 20 more flaws omitted

URL: /en-US/docs/Web/API/HTMLDialogElement/cancel_event
Title: HTMLDialogElement: cancel event
on GitHub
Flaw count: 1

  • macros:
    • /en-US/docs/Web/API/GlobalEventHandlers/oncancel does not exist

External URLs

URL: /en-US/docs/Web/API/GlobalEventHandlers
Title: GlobalEventHandlers
on GitHub

No external URLs

URL: /en-US/docs/Web/API/GlobalEventHandlers/onclose
Title: GlobalEventHandlers.onclose
on GitHub

No external URLs

URL: /en-US/docs/Web/API/HTMLDialogElement/cancel_event
Title: HTMLDialogElement: cancel event
on GitHub

No external URLs

(this comment was updated 2022-07-10 00:27:18.654489)

@teoli2003 teoli2003 removed the request for review from wbamberg July 8, 2022 17:41
teoli2003
teoli2003 suggested changes Jul 8, 2022
View reviewed changes
Copy link
Contributor

@teoli2003 teoli2003 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How did you the redirect? yarn content delete Web/API/GlobalEventHandlers/oncancel --redirect Web/API/HTMLInputElement/cancel_event should be the way.

That shouldn't create a broken test.

@queengooborg
Copy link
Collaborator Author

How did you the redirect? yarn content delete Web/API/GlobalEventHandlers/oncancel --redirect Web/API/HTMLInputElement/cancel_event should be the way.

That shouldn't create a broken test.

That's what I did, but I ran into problems with it. I just tried adding it again, but it's failing tests. Hmm...

@queengooborg
Copy link
Collaborator Author

Ah, that's why: HTMLInputElement/cancel_event doesn't exist! 😛

@teoli2003
Copy link
Contributor

There are a few conflicts here, too.

@queengooborg queengooborg merged commit 5a42163 into mdn:main Jul 10, 2022
@queengooborg queengooborg deleted the oncancel branch July 10, 2022 00:27
yin1999 added a commit to yin1999/translated-content that referenced this pull request Aug 1, 2022
@yin1999
Demix cancel event from GlobalEventHandlers
ac87fbf 
follow mdn/content#18115
yin1999 added a commit to mdn/translated-content that referenced this pull request Aug 2, 2022
@yin1999
Remove standard table from zh-CN documents (#7283)
c0e26a3 
* Drop Canvas hit regions content

follow mdn/content#8226

* remove non-standard File System related API

follow mdn/content#15815

* Demix cancel event from GlobalEventHandlers

follow mdn/content#18115

* Remove IDBEnvironment mixin page

follow mdn/content#8495

* Remove RenderingContext typedef

follow mdn/content#6592

* Remove Transferable from MDN

follow mdn/content#8880

* remove Window.isSecureContext

follow mdn/content#8351

* remove standard table
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teoli2003 teoli2003 teoli2003 approved these changes

Assignees
No one assigned
Labels
Content:WebAPI Web API docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@queengooborg @teoli2003