Refactor DocumentTimeline's discussion of time origin
#24011
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refer and link to "time origin" rather than the deprecated "navigationStart". Remove discussion of the "origin time" as it is always 0. A better place to discuss it would be `new DocumentTimeline()`, where it is configurable.
Refer to "time origin" rather than "navigationStart". Specify default value of "originTime" option.
|
Preview URLs (comment last updated: 2023-02-07 23:45:20) |
jpmedley
requested changes
Jan 31, 2023
|
Added missing |
jpmedley
approved these changes
Feb 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Replace references to
navigationStartwithtimeOrigin. Move discussion of "origin time" fromDocument.timelinetoDocumentTimeline(). Specify the defaultoriginTimeinDocumentTimline(). Add examples showing howoriginTimeworks. Define "non-active document".Motivation
Clarity, completeness.
navigationStartis marked obsolete, doesn't match the terminology in the standard, and isn't terribly relevant to animation in any case.The "origin time" discussion is redundant in
Document.timelinebecause that timeline's origin time is always zero, and therefore not terribly observable."Origin time" and "time origin" are both confusing and easily confused (w3c/csswg-drafts#2079); hopefully examples help with that a bit.