Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: slugs and titles in CSS module landing pages (f-s) #26958

Merged
merged 2 commits into from
May 29, 2023

Conversation

dipikabh
Copy link
Contributor

Description

This is the second in the series after #26939.

@dipikabh dipikabh requested review from a team as code owners May 25, 2023 02:59
@dipikabh dipikabh requested review from chrisdavidmills and removed request for a team May 25, 2023 02:59
@github-actions github-actions bot added the Content:CSS Cascading Style Sheets docs label May 25, 2023
@github-actions
Copy link
Contributor

github-actions bot commented May 25, 2023

Preview URLs (42 pages)
Flaws (16)

Note! 31 documents with no flaws that don't need to be listed. 🎉

URL: /en-US/docs/Web/CSS/CSS_overflow
Title: CSS overflow
Flaw count: 5

  • macros:
    • /en-US/docs/Web/CSS/block-ellipsis does not exist
    • /en-US/docs/Web/CSS/continue does not exist
    • /en-US/docs/Web/CSS/line-clamp does not exist
    • /en-US/docs/Web/CSS/max-lines does not exist
  • broken_links:
    • Can't resolve /en-US/docs/Web/CSS/CSSOM_View

URL: /en-US/docs/Web/CSS/CSS_grid_layout/Grid_layout_and_accessibility
Title: Grid layout and accessibility
Flaw count: 1

  • broken_links:
    • Can't resolve /en-US/docs/Web/CSS/Media_Queries

URL: /en-US/docs/Web/CSS/CSS_grid_layout/Relationship_of_grid_layout_with_other_layout_methods
Title: Relationship of grid layout to other layout methods
Flaw count: 1

  • broken_links:
    • Can't resolve /en-US/docs/Web/CSS/CSS_Columns

URL: /en-US/docs/Web/CSS/CSS_grid_layout/Grid_layout_and_progressive_enhancement
Title: CSS Grid Layout and progressive enhancement
Flaw count: 1

  • broken_links:
    • Can't resolve /en-US/docs/Web/CSS/Media_Queries

URL: /en-US/docs/Web/CSS/CSS_grid_layout/Realizing_common_layouts_using_grids
Title: Realizing common layouts using grids
Flaw count: 2

  • broken_links:
    • Can't resolve /en-US/docs/Web/CSS/Media_Queries
    • Can't resolve /en-US/docs/Web/CSS/Media_Queries

URL: /en-US/docs/Web/CSS/CSS_masking
Title: CSS masking
Flaw count: 1

  • macros:
    • /en-US/docs/Web/CSS/clip-rule does not exist

URL: /en-US/docs/Web/CSS/CSS_flow_layout
Title: CSS flow layout
Flaw count: 1

  • broken_links:
    • Can't resolve /en-US/docs/Web/CSS/CSS_Writing_Modes

URL: /en-US/docs/Web/CSS/CSS_flow_layout/Introduction_to_formatting_contexts
Title: Introduction to formatting contexts
Flaw count: 1

  • broken_links:
    • Can't resolve /en-US/docs/Web/CSS/CSS_Columns/Basic_Concepts_of_Multicol

URL: /en-US/docs/Web/CSS/CSS_flow_layout/Flow_layout_and_writing_modes
Title: Flow layout and writing modes
Flaw count: 1

  • broken_links:
    • Can't resolve /en-US/docs/Web/CSS/CSS_Writing_Modes

URL: /en-US/docs/Web/CSS/CSS_logical_properties_and_values
Title: CSS logical properties and values
Flaw count: 1

  • broken_links:
    • Can't resolve /en-US/docs/Web/CSS/CSS_Writing_Modes

URL: /en-US/docs/Web/CSS/CSS_logical_properties_and_values/Floating_and_positioning
Title: Logical properties for floating and positioning
Flaw count: 1

  • broken_links:
    • Can't resolve /en-US/docs/Web/CSS/CSS_Positioning
External URLs (13)

URL: /en-US/docs/Web/CSS/CSS_scroll_snap/Basic_concepts
Title: Basic concepts of scroll snap


URL: /en-US/docs/Web/CSS/CSS_grid_layout/Grid_layout_using_line-based_placement
Title: Grid layout using line-based placement


URL: /en-US/docs/Web/CSS/CSS_grid_layout/Realizing_common_layouts_using_grids
Title: Realizing common layouts using grids


URL: /en-US/docs/Web/CSS/CSS_grid_layout/Box_alignment_in_grid_layout
Title: Box alignment in grid layout


URL: /en-US/docs/Web/CSS/CSS_grid_layout/Grids_logical_values_and_writing_modes
Title: Grids, logical values, and writing modes


URL: /en-US/docs/Web/CSS/CSS_flow_layout/Flow_layout_and_writing_modes
Title: Flow layout and writing modes


URL: /en-US/docs/Web/CSS/CSS_logical_properties_and_values/Basic_concepts_of_logical_properties_and_values
Title: Basic concepts of logical properties and values

(comment last updated: 2023-05-29 08:35:55)

@github-actions
Copy link
Contributor

This pull request has merge conflicts that must be resolved before it can be merged.

- letters g and i module landing pages

- letter l module landing page

- letter f module landing page

- letter m module landing pages

- letters n, o, p module landing pages

- letters r and s module landing pages

- fix broken links

- fix broken links
@estelle
Copy link
Member

estelle commented May 27, 2023

@dipikabh there's an issue:

error: _redirects.txt for en-us is causing issues: Error: Invalid redirect for /en-US/docs/Web/CSS/CSS_Positioning -> /en-US/docs/Web/CSS/CSS_positioned_layout or /en-US/docs/Web/CSS/CSS_Pages -> /en-US/docs/Web/CSS/CSS_paged_media

@dipikabh
Copy link
Contributor Author

@dipikabh there's an issue:

error: _redirects.txt for en-us is causing issues: Error: Invalid redirect for /en-US/docs/Web/CSS/CSS_Positioning -> /en-US/docs/Web/CSS/CSS_positioned_layout or /en-US/docs/Web/CSS/CSS_Pages -> /en-US/docs/Web/CSS/CSS_paged_media

Yes, after I resolved the conflicts in the redirects and wikihistory files on Friday, I saw these redirects issue and so didn't proceed with the merge. I tested both those redirects locally and they're both working in my local preview, so I am not sure what the issue is. I was hoping to get some help from engineering but Monday is a bank holiday.

I am inclined to merge this anyway since the error is not blocking the merging, lest the branch goes stale.

@caugner
Copy link
Contributor

caugner commented May 29, 2023

FWIW @dipikabh Running yarn content fix-redirects fixed it. The cause of the error was that the redirects file was no longer alphabetically ordered after resolving the merge conflicts, see c89c4d0.

@caugner caugner merged commit f79a491 into mdn:main May 29, 2023
@dipikabh
Copy link
Contributor Author

Thanks a lot @caugner for troubleshooting and fixing this! 🙏

yin1999 added a commit to mdn/translated-content that referenced this pull request May 30, 2023
yin1999 added a commit to mdn/translated-content that referenced this pull request May 30, 2023
* zh-tw: sync translated content

* fix: slugs and titles in CSS module landing pages (f-s)

ref: mdn/content#26958

---------

Co-authored-by: allo <yin199909@aliyun.com>
yin1999 added a commit to mdn/translated-content that referenced this pull request May 30, 2023
yin1999 added a commit to mdn/translated-content that referenced this pull request May 30, 2023
* zh-cn: sync translated content

* fix: slugs and titles in CSS module landing pages (f-s)

ref: mdn/content#26958

* remove old sidebar sections

---------

Co-authored-by: allo <yin199909@aliyun.com>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Content:CSS Cascading Style Sheets docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants