-
Notifications
You must be signed in to change notification settings - Fork 22.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Technical Review: Documentation for the Attribution Reporting API #28471
Technical Review: Documentation for the Attribution Reporting API #28471
Conversation
This pull request has merge conflicts that must be resolved before it can be merged. |
Co-authored-by: Andrew Paseltiner <apaseltiner@google.com>
Co-authored-by: Andrew Paseltiner <apaseltiner@google.com>
Co-authored-by: Andrew Paseltiner <apaseltiner@google.com>
Co-authored-by: Andrew Paseltiner <apaseltiner@google.com>
Co-authored-by: Andrew Paseltiner <apaseltiner@google.com>
Co-authored-by: Andrew Paseltiner <apaseltiner@google.com>
…dex.md Co-authored-by: Andrew Paseltiner <apaseltiner@google.com>
Thanks again @apasel422. When comment threads get this big, I appreciate that it becomes easy to miss comments. I've therefore compiled a list of the exact links to comments where I still need your input:
|
files/en-us/web/api/attribution_reporting_api/generating_reports/index.md
Outdated
Show resolved
Hide resolved
files/en-us/web/api/attribution_reporting_api/generating_reports/index.md
Outdated
Show resolved
Hide resolved
files/en-us/web/api/attribution_reporting_api/generating_reports/index.md
Outdated
Show resolved
Hide resolved
files/en-us/web/api/attribution_reporting_api/generating_reports/index.md
Outdated
Show resolved
Hide resolved
files/en-us/web/api/attribution_reporting_api/generating_reports/index.md
Outdated
Show resolved
Hide resolved
files/en-us/web/http/headers/attribution-reporting-register-source/index.md
Outdated
Show resolved
Hide resolved
files/en-us/web/http/headers/attribution-reporting-register-source/index.md
Show resolved
Hide resolved
files/en-us/web/http/headers/attribution-reporting-register-trigger/index.md
Outdated
Show resolved
Hide resolved
files/en-us/web/http/headers/attribution-reporting-register-trigger/index.md
Outdated
Show resolved
Hide resolved
files/en-us/web/http/headers/attribution-reporting-register-trigger/index.md
Outdated
Show resolved
Hide resolved
files/en-us/web/api/attribution_reporting_api/registering_triggers/index.md
Outdated
Show resolved
Hide resolved
files/en-us/web/http/headers/attribution-reporting-register-trigger/index.md
Outdated
Show resolved
Hide resolved
files/en-us/web/api/attribution_reporting_api/generating_reports/index.md
Outdated
Show resolved
Hide resolved
files/en-us/web/api/attribution_reporting_api/registering_sources/index.md
Show resolved
Hide resolved
Thanks again for all the review work, @apasel422. Let me know if there are any more bits you think need updating. In addition, there are a couple more existing comments I just wanted to check that you had seen and had no further responses to:
We've got this outstanding still, as well: #28471 (comment) |
files/en-us/web/api/attribution_reporting_api/generating_reports/index.md
Show resolved
Hide resolved
files/en-us/web/api/attribution_reporting_api/generating_reports/index.md
Outdated
Show resolved
Hide resolved
…s/content into attribution-reporting-api
@chrisdavidmills Looks good to me. Given how complex this feature is, I'm sure we'll have future edits and enhancements, but this is an excellent start. |
@apasel422 Agreed. Thanks again for the superhuman reviewing effort to help get it to this state. I understand this API now much better than when you first started it, and the docs make more sense now. So, the next stage is to close this PR, and then open a new one based on the same branch to contain the editorial review. |
Note: This technical review is now completed and approved. For the follow-on editorial review, see #33172.
Description
The Attribution Reporting API is an integral part of Google's privacy sandbox technologies. Many parts of this set are being made available by default in Chrome 115 (depending on a gradual ramp-up to 100% of userbase over the 115 release period).
This PR provides documentation for the Attribution Reporting API and its related HTTP headers and other features.
See my research document for more details of exactly what changes are expected in the PR.
Motivation
Additional details
Related issues and pull requests