Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Technical Review: Documentation for the Attribution Reporting API #28471

Closed

Conversation

chrisdavidmills
Copy link
Contributor

@chrisdavidmills chrisdavidmills commented Aug 9, 2023

Note: This technical review is now completed and approved. For the follow-on editorial review, see #33172.


Description

The Attribution Reporting API is an integral part of Google's privacy sandbox technologies. Many parts of this set are being made available by default in Chrome 115 (depending on a gradual ramp-up to 100% of userbase over the 115 release period).

This PR provides documentation for the Attribution Reporting API and its related HTTP headers and other features.

See my research document for more details of exactly what changes are expected in the PR.

Motivation

Additional details

Related issues and pull requests

@chrisdavidmills chrisdavidmills requested review from a team as code owners August 9, 2023 12:39
@chrisdavidmills chrisdavidmills requested review from wbamberg, teoli2003, estelle and bsmth and removed request for a team August 9, 2023 12:39
@chrisdavidmills chrisdavidmills marked this pull request as draft August 9, 2023 12:39
@github-actions github-actions bot added Content:HTML Hypertext Markup Language docs Content:WebAPI Web API docs Content:HTTP HTTP docs labels Aug 9, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Aug 9, 2023

Preview URLs (25 pages)
Flaws (15)

Note! 22 documents with no flaws that don't need to be listed. 🎉

URL: /en-US/docs/Web/API/HTMLScriptElement
Title: HTMLScriptElement
Flaw count: 9

  • macros:
    • /en-US/docs/Web/API/HTMLScriptElement/type does not exist
    • /en-US/docs/Web/API/HTMLScriptElement/src does not exist
    • /en-US/docs/Web/API/HTMLScriptElement/event does not exist
    • /en-US/docs/Web/API/HTMLScriptElement/charset does not exist
    • /en-US/docs/Web/API/HTMLScriptElement/async does not exist
    • and 4 more flaws omitted

URL: /en-US/docs/Web/API/Attribution_Reporting_API/Generating_reports
Title: Generating attribution reports
Flaw count: 1

  • broken_links:
    • Can't resolve /en-US/docs/Web/Privacy/Third-party_cookies

URL: /en-US/docs/Web/API/HTMLAnchorElement
Title: HTMLAnchorElement
Flaw count: 5

  • macros:
    • /en-US/docs/Web/API/HTMLAnchorElement/charset does not exist
    • /en-US/docs/Web/API/HTMLAnchorElement/coords does not exist
    • /en-US/docs/Web/API/HTMLAnchorElement/name does not exist
    • /en-US/docs/Web/API/HTMLAnchorElement/rev does not exist
    • /en-US/docs/Web/API/HTMLAnchorElement/shape does not exist
External URLs (24)

URL: /en-US/docs/Web/API/Attribution_Reporting_API
Title: Attribution Reporting API


URL: /en-US/docs/Web/API/Attribution_Reporting_API/Registering_sources
Title: Registering attribution sources


URL: /en-US/docs/Web/API/Attribution_Reporting_API/Registering_triggers
Title: Registering attribution triggers


URL: /en-US/docs/Web/API/Attribution_Reporting_API/Generating_reports
Title: Generating attribution reports


URL: /en-US/docs/Web/HTTP/Headers/Attribution-Reporting-Register-Trigger
Title: Attribution-Reporting-Register-Trigger

(comment last updated: 2024-04-18 07:51:18)

@chrisdavidmills chrisdavidmills changed the title Draft documentation for the Attribution Reporting API Documentation for the Attribution Reporting API Aug 18, 2023
@chrisdavidmills chrisdavidmills marked this pull request as ready for review October 2, 2023 16:56
@github-actions github-actions bot added the merge conflicts 🚧 [PR only] label Oct 8, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Oct 8, 2023

This pull request has merge conflicts that must be resolved before it can be merged.

chrisdavidmills and others added 9 commits April 2, 2024 09:18
Co-authored-by: Andrew Paseltiner <apaseltiner@google.com>
Co-authored-by: Andrew Paseltiner <apaseltiner@google.com>
Co-authored-by: Andrew Paseltiner <apaseltiner@google.com>
Co-authored-by: Andrew Paseltiner <apaseltiner@google.com>
Co-authored-by: Andrew Paseltiner <apaseltiner@google.com>
Co-authored-by: Andrew Paseltiner <apaseltiner@google.com>
…dex.md

Co-authored-by: Andrew Paseltiner <apaseltiner@google.com>
@chrisdavidmills
Copy link
Contributor Author

Thanks again for all the review work, @apasel422. Let me know if there are any more bits you think need updating.

In addition, there are a couple more existing comments I just wanted to check that you had seen and had no further responses to:

We've got this outstanding still, as well: #28471 (comment)

@apasel422
Copy link
Contributor

@chrisdavidmills Looks good to me. Given how complex this feature is, I'm sure we'll have future edits and enhancements, but this is an excellent start.

@chrisdavidmills
Copy link
Contributor Author

@chrisdavidmills Looks good to me. Given how complex this feature is, I'm sure we'll have future edits and enhancements, but this is an excellent start.

@apasel422 Agreed. Thanks again for the superhuman reviewing effort to help get it to this state. I understand this API now much better than when you first started it, and the docs make more sense now.

So, the next stage is to close this PR, and then open a new one based on the same branch to contain the editorial review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:HTML Hypertext Markup Language docs Content:HTTP HTTP docs Content:Other Any docs not covered by another "Content:" label Content:WebAPI Web API docs size/xl [PR only] >1000 LoC changed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants