Sync <hue> and <hue-interpolation-method> with spec
#28943
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yarusome
requested review from
chrisdavidmills
and removed request for
a team
|
Preview URLs Flaws (1)Note! 1 document with no flaws that don't need to be listed. 🎉 URL:
(comment last updated: 2023-09-20 08:55:09) |
yarusome
changed the title
<hue-interpolation-method> with spec<hue> and <hue-interpolation-method> with spec
bsmth
reviewed
Sep 7, 2023
There was a problem hiding this comment.
Hi @yarusome! I've provided a review and made some suggestions. I'm not sure how helpful I've been really, as this is pretty complex maths stuff and I don't really understand it. I wonder if there is someone in our peers who would do a better reviewing job than me for this one.
chrisdavidmills
approved these changes
Sep 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR:
increasing hueanddecreasing huefor<hue-interpolation-method>;<hue-interpolation-method>;<hue>.Motivation
Per w3c/csswg-drafts@2641c47 and w3c/csswg-drafts@f46b5d4.
Additional details
Related issues and pull requests
Fixes #28986.