Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add json to possible fetch destinations #29573

Merged
merged 2 commits into from
Apr 9, 2024
Merged

Add json to possible fetch destinations #29573

merged 2 commits into from
Apr 9, 2024

Conversation

nicolo-ribaudo
Copy link
Contributor

Description

The fetch spec is being updated to support a json destination. This PR adds it to the list of valid destination.

Additional details

whatwg/fetch#1691

@nicolo-ribaudo nicolo-ribaudo requested a review from a team as a code owner October 10, 2023 09:16
@nicolo-ribaudo nicolo-ribaudo requested review from Elchi3 and removed request for a team October 10, 2023 09:16
@nicolo-ribaudo nicolo-ribaudo mentioned this pull request Oct 10, 2023
Merged
4 tasks
@github-actions github-actions bot added the Content:WebAPI Web API docs label Oct 10, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Oct 10, 2023 •
edited
Loading

Preview URLs

(comment last updated: 2024-03-05 11:51:28)

@wbamberg wbamberg added the waiting for implementations Waiting for feature to be implemented in browsers label Oct 10, 2023
@Elchi3 Elchi3 marked this pull request as draft October 28, 2023 10:02
@Elchi3 Elchi3 removed their request for review October 28, 2023 10:02
@nicolo-ribaudo
Copy link
Contributor Author

I'm marking this as ready because the spec has been merged, but there are no implementations yet.

@nicolo-ribaudo nicolo-ribaudo marked this pull request as ready for review October 30, 2023 08:22
@github-actions github-actions bot added the merge conflicts 🚧 [PR only] label Mar 5, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 5, 2024

This pull request has merge conflicts that must be resolved before it can be merged.

@github-actions github-actions bot added size/xs [PR only] 0-5 LoC changed and removed merge conflicts 🚧 [PR only] labels Mar 5, 2024
@nicolo-ribaudo
Copy link
Contributor Author

This is now released in at least one browser (Chrome)

@bsmth bsmth removed the waiting for implementations Waiting for feature to be implemented in browsers label Mar 26, 2024
@bsmth
Copy link
Member

bsmth commented Mar 26, 2024

Thanks a lot for opening this one. Are there any other areas that make sense to add this? Sec-Fetch-Dest?

It looks like this is in Chrome 123, right?

bsmth
bsmth approved these changes Apr 9, 2024
View reviewed changes
Copy link
Member

@bsmth bsmth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm going to merge for now and follow-up about https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Sec-Fetch-Dest shortly 👍🏻

@bsmth bsmth merged commit b6b02dc into mdn:main Apr 9, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bsmth bsmth bsmth approved these changes

Assignees
No one assigned
Labels
Content:WebAPI Web API docs size/xs [PR only] 0-5 LoC changed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nicolo-ribaudo @bsmth @wbamberg