-
Notifications
You must be signed in to change notification settings - Fork 22.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(html): update resolution switching demo pros #30902
Conversation
Preview URLs External URLs (1)URL:
(comment last updated: 2024-05-04 02:12:08) |
files/en-us/learn/html/multimedia_and_embedding/responsive_images/index.md
Outdated
Show resolved
Hide resolved
files/en-us/learn/html/multimedia_and_embedding/responsive_images/index.md
Outdated
Show resolved
Hide resolved
@OnkarRuikar Thanks very much. I've subedited the English a little. I haven't approved because even though this is better, do you think we could improve the example by displaying the three source images below, allowing the user to compare the versions they might get on each screen (and noting that you would only see the benefit on a higher resolution screen)? Most of the time this should be useful and make the effects more obvious, in particular because we most people will have better than the crappiest screen by default. |
@hamishwillee I've updated the example in |
d208fe8
to
f0d11a6
Compare
This pull request has merge conflicts that must be resolved before it can be merged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks very much
The updates assert that the rendered image size doesn't change but the image quality does change on higher resolution displays.