-
Notifications
You must be signed in to change notification settings - Fork 22.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document Compute Pressure API #32923
Conversation
Preview URLs (16 pages)
Flaws (14)Note! 2 documents with no flaws that don't need to be listed. 🎉 URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
External URLs (4)URL:
URL:
(comment last updated: 2024-05-13 08:12:57) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just left a couple of comments. Looks pretty good already, thanks for documenting this!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Florian!
files/en-us/web/http/headers/permissions-policy/compute-pressure/index.md
Outdated
Show resolved
Hide resolved
files/en-us/web/http/headers/permissions-policy/compute-pressure/index.md
Show resolved
Hide resolved
Co-authored-by: Thomas Steiner <tomac@google.com> Co-authored-by: wbamberg <will@bootbonnet.ca>
Thanks everyone, I went through all the comments. I think the outstanding questions are:
|
I've addressed the review feedback and updated the docs per the latest spec change (supportedSources -> knownSources). I've also merged the BCD so that we can have spec and compat sections in the docs. Marking as ready for final review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the updates Florian. I had some tiny comments.
Co-authored-by: wbamberg <will@bootbonnet.ca>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 thank you Florian!
Description
This pull request documents the Compute Pressure API.
Technical reviewers: @kenchris, @arskama
Additional details
This PR creates the following pages:
A more hands-on "Using the Compute Pressure API" guide page could be added in a follow-up PR.
Related issues and pull requests