Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: editorial review: Update cookie docs #33138

Merged
merged 44 commits into from
May 2, 2024

Conversation

chrisdavidmills
Copy link
Contributor

Description

#31848 contains the engineering technical review for my work on updating the MDN cookie docs, which has been completed and approved. Thank you to @samdutton for your thorough and detailed review work.

This is a new PR based on the same branch, which is intended to contain the editorial review for the same work.


Background information

This PR updates some of the cookie information found on MDN, according to the cookie docs proposal that was made available a while ago.

While this PR doesn't make all of the changes listed in the proposal doc, it does the following:

  • Update the HTTP cookies guide to clean up the structure a bit, modernize the information, and move some of the information to other places.
  • Add a new Third-party cookies article to provide a single detailed definition of 3PC, the issues associated with them, and how to handle those issues.
  • Clean up the Privacy landing page to remove some of the browser-specific information, move some of the content to more appropriate places, and generally clean up/improve.
  • Update all the pages that provide their own definition of third-party cookies/tracking and link them to the one single definition on the new 3PC article instead.

Motivation

Additional details

Related issues and pull requests

@chrisdavidmills chrisdavidmills requested review from a team as code owners April 17, 2024 17:58
@chrisdavidmills chrisdavidmills requested review from Rob--W and Elchi3 and removed request for a team April 17, 2024 17:58
@github-actions github-actions bot added the Content:WebExt WebExtensions docs label Apr 17, 2024
chrisdavidmills and others added 18 commits April 24, 2024 12:11
Co-authored-by: Jean-Yves Perrier <jypenator@gmail.com>
Co-authored-by: Jean-Yves Perrier <jypenator@gmail.com>
Co-authored-by: Jean-Yves Perrier <jypenator@gmail.com>
Co-authored-by: Jean-Yves Perrier <jypenator@gmail.com>
Co-authored-by: Jean-Yves Perrier <jypenator@gmail.com>
Co-authored-by: Jean-Yves Perrier <jypenator@gmail.com>
Co-authored-by: Jean-Yves Perrier <jypenator@gmail.com>
Co-authored-by: Jean-Yves Perrier <jypenator@gmail.com>
Co-authored-by: Jean-Yves Perrier <jypenator@gmail.com>
Co-authored-by: Jean-Yves Perrier <jypenator@gmail.com>
Co-authored-by: Jean-Yves Perrier <jypenator@gmail.com>
Co-authored-by: Jean-Yves Perrier <jypenator@gmail.com>
Co-authored-by: Jean-Yves Perrier <jypenator@gmail.com>
Co-authored-by: Jean-Yves Perrier <jypenator@gmail.com>
Co-authored-by: Jean-Yves Perrier <jypenator@gmail.com>
Co-authored-by: Jean-Yves Perrier <jypenator@gmail.com>
Co-authored-by: Jean-Yves Perrier <jypenator@gmail.com>
@chrisdavidmills
Copy link
Contributor Author

In addition to the inline comments, we need to double-check if the drawio files can be stored there. I hope this, but I don't remember the outcome of a former discussion (@bsmth: do you remember?)

Thanks a lot for checking. Could we please move them to https://github.com/mdn/shared-assets/tree/main/images/diagrams? There is also GH pages active on that repo, so you can reference images / SVG like: https://mdn.github.io/shared-assets/images/examples/balloon-small.jpg

Related discussions:

* https://github.com/orgs/mdn/discussions/94

* https://github.com/orgs/mdn/discussions/631#discussioncomment-8222396

Ah, thanks a lot for bringing this to my attention, @teoli2003, and thanks for the info, @bsmth. This discussion completely passed me by; I am really glad we have a place for shared images now!

I will immediately put my image files on the shared-assets repo, before I continue with the rest of the work in this PR.

@chrisdavidmills
Copy link
Contributor Author

@teoli2003 thanks for the fabulous review. I've responded to everything now. Back to you!

Copy link
Contributor

@teoli2003 teoli2003 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good to me.

Thank you!

@teoli2003 teoli2003 merged commit 6acc0b4 into mdn:main May 2, 2024
8 checks passed
@chrisdavidmills chrisdavidmills deleted the update-cookie-docs branch May 2, 2024 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:HTTP HTTP docs Content:Other Any docs not covered by another "Content:" label Content:Security Security docs Content:WebAPI Web API docs Content:WebExt WebExtensions docs size/l [PR only] 501-1000 LoC changed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants