-
Notifications
You must be signed in to change notification settings - Fork 22.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
glossary: update attribute #33386
glossary: update attribute #33386
Conversation
Preview URLs Flaws (2)URL:
External URLs (1)URL:
(comment last updated: 2024-05-07 09:50:09) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@PassionPenguin nice work! I had a few language suggestions for you, but nothing major.
<input required="" /> | ||
<!-- or --> | ||
<input required="required" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Surely it is still equivalent to this as well? Include this one as well as the other one?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i have mixed with the original document (line 13’s removal or the attribute's name in XML.
). this is indeed equivalence of html attr=“attr”
.
(i’ve checked html spec from + to 5, and in all specs, boolean attribute is true only requires the attribute to exists)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That is super interesting — I thought it would have to be required="required"
to work, but I tested it and you are correct — it can indeed be required="anything"
.
Today I learned something ;-)
thx for your kindly corrections! (sorry for having so many problems in the updation) |
Co-authored-by: Chris Mills <chrisdavidmills@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great; thank you for your work on this, @PassionPenguin!
* update: xml attribute * Apply suggestions from code review Co-authored-by: Chris Mills <chrisdavidmills@gmail.com> * add equivalence --------- Co-authored-by: Chris Mills <chrisdavidmills@gmail.com>
Description
xml attribute behaviour fixes
Motivation
=
and"value"
is not allowed and will throw an error of "the spec mandates value for attribute #attr"attr eq value
Additional details
tested that will throw an error:
<tag id />
Related issues and pull requests