Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add docs for SVGElement.attributeStyleMap and MathMLElement.attributeStyleMap #33642

Merged
merged 2 commits into from
Jun 13, 2024
Merged

Add docs for SVGElement.attributeStyleMap and MathMLElement.attributeStyleMap #33642

merged 2 commits into from
Jun 13, 2024

Conversation

skyclouds2001
Copy link
Contributor

@skyclouds2001 skyclouds2001 commented May 16, 2024 •
edited
Loading

Description

Motivation

Additional details

Related issues and pull requests

relates to #31626

relates to mdn/browser-compat-data#23112

@github-actions github-actions bot added Content:WebAPI Web API docs size/m [PR only] 51-500 LoC changed labels May 16, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 16, 2024 •
edited
Loading

Preview URLs (6 pages)
Flaws (10)

Note! 5 documents with no flaws that don't need to be listed. 🎉

URL: /en-US/docs/Web/API/SVGElement
Title: SVGElement
Flaw count: 10

  • macros:
    • /en-US/docs/Web/API/SVGElement/dataset does not exist
    • /en-US/docs/Web/API/SVGElement/className does not exist
    • /en-US/docs/Web/API/SVGElement/nonce does not exist
    • /en-US/docs/Web/API/SVGElement/ownerSVGElement does not exist
    • /en-US/docs/Web/API/SVGElement/tabIndex does not exist
    • and 1 more flaws omitted
  • broken_links:
    • Can't resolve /en-US/docs/Web/API/SVGElement/abort_event
    • Can't resolve /en-US/docs/Web/API/SVGElement/resize_event
    • Can't resolve /en-US/docs/Web/API/SVGElement/scroll_event
    • Can't resolve /en-US/docs/Web/API/SVGElement/unload_event

(comment last updated: 2024-06-12 12:16:22)

@skyclouds2001 skyclouds2001 mentioned this pull request May 16, 2024
Merged
@skyclouds2001 skyclouds2001 marked this pull request as ready for review June 12, 2024 11:53
@skyclouds2001 skyclouds2001 requested a review from a team as a code owner June 12, 2024 11:53
@skyclouds2001 skyclouds2001 requested review from sideshowbarker and removed request for a team June 12, 2024 11:53
@sideshowbarker sideshowbarker removed their request for review June 12, 2024 16:21
hamishwillee
hamishwillee reviewed Jun 13, 2024
View reviewed changes
files/en-us/web/api/htmlelement/attributestylemap/index.md
@@ -8,7 +8,7 @@ browser-compat: api.HTMLElement.attributeStyleMap

{{APIRef("CSSOM")}}

The **`attributeStyleMap`** read-only property of the {{domxref("HTMLElement")}} interface returns a live {{domxref("StylePropertyMap")}} object that contains a list of style properties of the element that are defined in the element's inline [`style`](/en-US/docs/Web/HTML/Global_attributes/style) attribute, or assigned using the {{domxref("HTMLElement.style", "style")}} property of the {{domxref("HTMLElement")}} interface via script.
The **`attributeStyleMap`** read-only property of the {{domxref("HTMLElement")}} interface returns a live {{domxref("StylePropertyMap")}} object that contains a list of style properties of the element that are defined in the element's inline `style` attribute, or assigned using the {{domxref("HTMLElement.style", "style")}} property of the {{domxref("HTMLElement")}} interface via script.
Copy link
Collaborator

@hamishwillee hamishwillee Jun 13, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please dont bother changing to the macro format. MDN does not expect a particular style, so from a reviewer point of view this is noise.

hamishwillee
hamishwillee reviewed Jun 13, 2024
View reviewed changes
files/en-us/web/api/htmlelement/attributestylemap/index.md
@@ -8,7 +8,7 @@ browser-compat: api.HTMLElement.attributeStyleMap

{{APIRef("CSSOM")}}

The **`attributeStyleMap`** read-only property of the {{domxref("HTMLElement")}} interface returns a live {{domxref("StylePropertyMap")}} object that contains a list of style properties of the element that are defined in the element's inline [`style`](/en-US/docs/Web/HTML/Global_attributes/style) attribute, or assigned using the {{domxref("HTMLElement.style", "style")}} property of the {{domxref("HTMLElement")}} interface via script.
The **`attributeStyleMap`** read-only property of the {{domxref("HTMLElement")}} interface returns a live {{domxref("StylePropertyMap")}} object that contains a list of style properties of the element that are defined in the element's inline `style` attribute, or assigned using the {{domxref("HTMLElement.style", "style")}} property of the {{domxref("HTMLElement")}} interface via script.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume by "live" you mean dynamically updated? Doesn't matter, looks good to me :-)

hamishwillee
hamishwillee approved these changes Jun 13, 2024
View reviewed changes
Copy link
Collaborator

@hamishwillee hamishwillee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks very much!

@hamishwillee hamishwillee merged commit 2eacf35 into mdn:main Jun 13, 2024
8 checks passed
@skyclouds2001 skyclouds2001 deleted the SVGElement,MathMLElement.attributeStyleMap branch June 14, 2024 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hamishwillee hamishwillee hamishwillee approved these changes

Assignees
No one assigned
Labels
Content:WebAPI Web API docs size/m [PR only] 51-500 LoC changed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@skyclouds2001 @hamishwillee