Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix globals, part 11: fetch() #33643

Merged
merged 14 commits into from
Jul 16, 2024
Merged

Fix globals, part 11: fetch() #33643

merged 14 commits into from
Jul 16, 2024

Conversation

skyclouds2001
Copy link
Contributor

@skyclouds2001 skyclouds2001 commented May 16, 2024

Description

Motivation

Additional details

and note that their are too many redirects (181 (1 + 135 + 4 + 41) matches in 141 files(1 + 105 + 4 + 31)), the update to the redirects will be done in other PRs

Related issues and pull requests

part of the #33019

\cc @wbamberg

@github-actions github-actions bot added Content:WebAPI Web API docs size/m [PR only] 51-500 LoC changed labels May 16, 2024
@skyclouds2001 skyclouds2001 changed the title Fetch Fix globals, part 11: fetch() May 16, 2024
Copy link
Contributor

github-actions bot commented May 16, 2024

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@github-actions github-actions bot added the merge conflicts 🚧 [PR only] label Jun 2, 2024
Copy link
Contributor

github-actions bot commented Jun 2, 2024

This pull request has merge conflicts that must be resolved before it can be merged.

@github-actions github-actions bot removed the merge conflicts 🚧 [PR only] label Jun 4, 2024
@github-actions github-actions bot added the merge conflicts 🚧 [PR only] label Jul 2, 2024
Copy link
Contributor

github-actions bot commented Jul 2, 2024

This pull request has merge conflicts that must be resolved before it can be merged.

@github-actions github-actions bot removed the merge conflicts 🚧 [PR only] label Jul 9, 2024
@skyclouds2001 skyclouds2001 marked this pull request as ready for review July 9, 2024 07:02
@skyclouds2001 skyclouds2001 requested review from a team as code owners July 9, 2024 07:02
@skyclouds2001 skyclouds2001 requested review from Elchi3 and pepelsbey and removed request for a team July 9, 2024 07:02
@bsmth
Copy link
Member

bsmth commented Jul 11, 2024

Thanks a lot! I've left a couple of comments for you.
When you say:

and note that their are too many redirects (181 (1 + 135 + 4 + 41) matches in 141 files(1 + 105 + 4 + 31)), the update to the redirects will be done in other PRs

Where are the redirects? Is it in markdown cross-references (internal links)? Or what do you plan to update in a follow-up?

@skyclouds2001
Copy link
Contributor Author

Thanks a lot! I've left a couple of comments for you. When you say:

and note that their are too many redirects (181 (1 + 135 + 4 + 41) matches in 141 files(1 + 105 + 4 + 31)), the update to the redirects will be done in other PRs

Where are the redirects? Is it in markdown cross-references (internal links)? Or what do you plan to update in a follow-up?

for example, like {{domxref("fetch()")}} or markdown link, these usages need to update accordingly to {domxref("Window.fetch", "fetch()")}} or {domxref("WorkerGlobalScope.fetch", "fetch()")}}

I've done a part of them, and is planing to make it in another PR future

@skyclouds2001 skyclouds2001 requested a review from bsmth July 16, 2024 07:39
@bsmth
Copy link
Member

bsmth commented Jul 16, 2024

Just to confirm; existing {{domxref("fetch()")}} macros won't break after this merge, we need to update them for disambiguation, right? Otherwise everything looks good to me!

Copy link
Member

@bsmth bsmth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you. Some comments open for prose fixes, but I think we're ready to go!

@skyclouds2001
Copy link
Contributor Author

Just to confirm; existing {{domxref("fetch()")}} macros won't break after this merge, we need to update them for disambiguation, right? Otherwise everything looks good to me!

Yes, existing {{domxref("fetch()")}} macros will still work and will redirect to Window.fetch

Co-authored-by: Brian Thomas Smith <brian@smith.berlin>
@bsmth
Copy link
Member

bsmth commented Jul 16, 2024

Super, then let's merge. Thank you!

@bsmth bsmth merged commit 80d3325 into mdn:main Jul 16, 2024
9 checks passed
yin1999 added a commit to mdn/translated-content that referenced this pull request Jul 17, 2024
yin1999 added a commit to mdn/translated-content that referenced this pull request Jul 17, 2024
@skyclouds2001 skyclouds2001 deleted the fetch branch July 18, 2024 01:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:WebAPI Web API docs size/m [PR only] 51-500 LoC changed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants