-
Notifications
You must be signed in to change notification settings - Fork 22.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix globals, part 11: fetch()
#33643
Conversation
Preview URLs
(comment last updated: 2024-07-16 14:12:33) |
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This pull request has merge conflicts that must be resolved before it can be merged. |
This pull request has merge conflicts that must be resolved before it can be merged. |
Thanks a lot! I've left a couple of comments for you.
Where are the redirects? Is it in markdown cross-references (internal links)? Or what do you plan to update in a follow-up? |
for example, like {{domxref("fetch()")}} or markdown link, these usages need to update accordingly to {domxref("Window.fetch", "fetch()")}} or {domxref("WorkerGlobalScope.fetch", "fetch()")}} I've done a part of them, and is planing to make it in another PR future |
Just to confirm; existing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you. Some comments open for prose fixes, but I think we're ready to go!
Yes, existing |
Co-authored-by: Brian Thomas Smith <brian@smith.berlin>
Super, then let's merge. Thank you! |
Description
Motivation
Additional details
and note that their are too many redirects (181 (1 + 135 + 4 + 41) matches in 141 files(1 + 105 + 4 + 31)), the update to the redirects will be done in other PRs
Related issues and pull requests
part of the #33019
\cc @wbamberg