Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

setSelectionRange update #33799

Merged
merged 3 commits into from
May 29, 2024
Merged

setSelectionRange update #33799

merged 3 commits into from
May 29, 2024

Conversation

wbamberg
Copy link
Collaborator

Looking at #33684, I thought the https://developer.mozilla.org/en-US/docs/Web/API/HTMLInputElement/setSelectionRange page could use a better description of exceptions.

2 commits:

  • the first one: 156d8c0 is just reformatting
  • the second: 622f5a8 has substantive changes

@wbamberg wbamberg requested a review from a team as a code owner May 28, 2024 19:08
@wbamberg wbamberg requested review from Elchi3 and removed request for a team May 28, 2024 19:08
@github-actions github-actions bot added the Content:WebAPI Web API docs label May 28, 2024
@wbamberg wbamberg changed the title Setselectionrange update setSelectionRange update May 28, 2024
@github-actions github-actions bot added the size/s [PR only] 6-50 LoC changed label May 28, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 28, 2024 •
edited
Loading

Preview URLs

(comment last updated: 2024-05-28 19:10:38)

Elchi3
Elchi3 approved these changes May 29, 2024
View reviewed changes
Copy link
Member

@Elchi3 Elchi3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you Will! 👍

@Elchi3 Elchi3 merged commit 76960f0 into mdn:main May 29, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Elchi3 Elchi3 Elchi3 approved these changes

Assignees
No one assigned
Labels
Content:WebAPI Web API docs size/s [PR only] 6-50 LoC changed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wbamberg @Elchi3