Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

33895 button accessibility #33916

Merged
merged 6 commits into from
Jun 6, 2024
Merged

33895 button accessibility #33916

merged 6 commits into from
Jun 6, 2024

Conversation

estelle
Copy link
Member

@estelle estelle commented Jun 4, 2024 •
edited
Loading

addresses #33895 and possibly #33283

@estelle estelle requested a review from a team as a code owner June 4, 2024 18:09
@estelle estelle requested review from chrisdavidmills and removed request for a team June 4, 2024 18:09
@github-actions github-actions bot added Content:HTML Hypertext Markup Language docs size/s [PR only] 6-50 LoC changed labels Jun 4, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 4, 2024 •
edited
Loading

Preview URLs

External URLs (2)

URL: /en-US/docs/Web/HTML/Element/button
Title: <button>: The Button element

(comment last updated: 2024-06-06 07:50:38)

@estelle @github-actions
Update files/en-us/web/html/element/button/index.md
ed77af1 
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@estelle estelle mentioned this pull request Jun 4, 2024
Open
chrisdavidmills
chrisdavidmills requested changes Jun 5, 2024
View reviewed changes
Copy link
Contributor

@chrisdavidmills chrisdavidmills left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of suggestions

files/en-us/web/html/element/button/index.md Outdated Show resolved Hide resolved
files/en-us/web/html/element/button/index.md Outdated Show resolved Hide resolved
@estelle @chrisdavidmills
Apply suggestions from code review
2c39612 
Co-authored-by: Chris Mills <chrisdavidmills@gmail.com>
estelle and others added 2 commits June 5, 2024 12:17
@estelle @github-actions
Update files/en-us/web/html/element/button/index.md
f7ed700 
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@estelle
Merge branch 'main' into estelle-patch-7
927b61d
chrisdavidmills
chrisdavidmills approved these changes Jun 6, 2024
View reviewed changes
Copy link
Contributor

@chrisdavidmills chrisdavidmills left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@estelle LGTM! Although I noticed that my suggestion that you committed had a borked link in it. Sorry about that. I'll fix it before I merge it.

@chrisdavidmills chrisdavidmills merged commit 54777ff into main Jun 6, 2024
9 checks passed
@chrisdavidmills chrisdavidmills deleted the estelle-patch-7 branch June 6, 2024 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@chrisdavidmills chrisdavidmills chrisdavidmills approved these changes

Assignees
No one assigned
Labels
Content:HTML Hypertext Markup Language docs size/s [PR only] 6-50 LoC changed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@estelle @chrisdavidmills