Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consistent param description for methods taking promises #34277

Merged
merged 1 commit into from
Jun 20, 2024
Merged

Consistent param description for methods taking promises #34277

merged 1 commit into from
Jun 20, 2024

Conversation

Josh-Cena
Copy link
Member

Fix #9362

@Josh-Cena Josh-Cena requested a review from a team as a code owner June 19, 2024 23:34
@Josh-Cena Josh-Cena requested review from sideshowbarker and removed request for a team June 19, 2024 23:34
@github-actions github-actions bot added Content:WebAPI Web API docs size/s [PR only] 6-50 LoC changed labels Jun 19, 2024
@github-actions GitHub Actions
Copy link
Contributor

Preview URLs

External URLs (2)

URL: /en-US/docs/Web/API/PaymentRequestEvent/respondWith
Title: PaymentRequestEvent: respondWith() method

hamishwillee
hamishwillee approved these changes Jun 20, 2024
View reviewed changes
Copy link
Collaborator

@hamishwillee hamishwillee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good thanks.

@hamishwillee hamishwillee merged commit 08aa2f3 into mdn:main Jun 20, 2024
7 checks passed
@Josh-Cena Josh-Cena deleted the promise-param branch June 20, 2024 23:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hamishwillee hamishwillee hamishwillee approved these changes

@sideshowbarker sideshowbarker Awaiting requested review from sideshowbarker sideshowbarker is a code owner automatically assigned from mdn/yari-content-web-api

Assignees
No one assigned
Labels
Content:WebAPI Web API docs size/s [PR only] 6-50 LoC changed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Content bug: inconsistent/incomplete descriptions of Promises as parameters
2 participants
@Josh-Cena @hamishwillee