Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(http): Add SVG diagrams for HTTP pages #34314

Merged
merged 3 commits into from
Jun 21, 2024

Conversation

bsmth
Copy link
Member

@bsmth bsmth commented Jun 21, 2024

Description

This PR removes .PNGs to use SVG format. The mermaid source are added to shared assets repo already.

Motivation

Reducing binary assets, maintenance of diagrams by adding source files.

Related issues and pull requests

Shared assets

Source and generated files for these changes:

@bsmth bsmth requested a review from a team as a code owner June 21, 2024 10:21
@bsmth bsmth requested review from teoli2003 and removed request for a team June 21, 2024 10:21
@github-actions github-actions bot added Content:HTTP HTTP docs size/s [PR only] 6-50 LoC changed labels Jun 21, 2024
@bsmth bsmth added reduce binary assets Efforts to remove or convert binary assets and removed size/s [PR only] 6-50 LoC changed labels Jun 21, 2024
Copy link
Contributor

Preview URLs

Flaws (4)

Note! 1 document with no flaws that don't need to be listed. 🎉

URL: /en-US/docs/Web/HTTP/Authentication
Title: HTTP authentication
Flaw count: 1

  • images:
    • External image URL

URL: /en-US/docs/Web/HTTP/CORS
Title: Cross-Origin Resource Sharing (CORS)
Flaw count: 3

  • images:
    • External image URL
    • External image URL
    • External image URL

@sideshowbarker sideshowbarker merged commit fa33a91 into mdn:main Jun 21, 2024
7 checks passed
@bsmth bsmth deleted the http-keyed-diagrams branch June 24, 2024 07:53
@bsmth
Copy link
Member Author

bsmth commented Jun 24, 2024

Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:HTTP HTTP docs reduce binary assets Efforts to remove or convert binary assets
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants