Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Template engines link fix - list the main engines #34527

Merged
merged 1 commit into from
Jul 1, 2024

Conversation

hamishwillee
Copy link
Collaborator

Express have no useful links anymore to template engines other than the main ones - Pug, EJS, Moustache. I've mirrored this by listing those main libraries and referring to them as "notable".

I'm relatively happy with this. The original doc assumed you might have a strong preference for a particular templating engine, but in fact most support fairly similar syntax and concepts. Three is more than enough to list and people can search if they want to find if their preferred engine is supported.

Fixes #34481

@hamishwillee hamishwillee requested a review from a team as a code owner July 1, 2024 04:57
@hamishwillee hamishwillee requested review from teoli2003 and removed request for a team July 1, 2024 04:57
@github-actions github-actions bot added the Content:Learn:Express Learning area Express docs label Jul 1, 2024
@github-actions github-actions bot added the size/s [PR only] 6-50 LoC changed label Jul 1, 2024
Copy link
Contributor

github-actions bot commented Jul 1, 2024

Copy link
Member

@bsmth bsmth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with this! Note there's a warning on startup:

npx express-generator


  warning: the default view engine will not be jade in future releases
  warning: use `--view=jade' or `--help' for additional options

But the commit history for the generator shows the warning's been added 10 years ago, so let's continue with this for now!

Thank you!

@bsmth bsmth merged commit 37272e4 into mdn:main Jul 1, 2024
7 checks passed
@hamishwillee
Copy link
Collaborator Author

Thanks, yes I'm aware. That's why I added "notably Pug (formerly "Jade"),". The express generator is not well maintained but it is better than getting our readers to start from scratch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:Learn:Express Learning area Express docs size/s [PR only] 6-50 LoC changed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Express-introduction: Broken link
2 participants