Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(css): mention 'auto' value in outline-color as unsupported in any browser #34551

Merged
merged 2 commits into from
Jul 10, 2024

Conversation

TrySound
Copy link
Contributor

@TrySound TrySound commented Jul 2, 2024

Description

Remove auto keyword from outline-color possible values

Motivation

outline-color is not supported in any browser and mdn does not show it in compatibility table making an impression it is well supported.

Related issues and pull requests

Reverts #29798

See mdn/browser-compat-data#23538 (comment)

Reverts mdn#29798

See mdn/browser-compat-data#23538 (comment)

outline-color is not supported in any browser though [mdn](https://developer.mozilla.org/en-US/docs/Web/CSS/outline-color)
does not show it in compatibility table making an impression it is well
supported.
@TrySound TrySound requested a review from a team as a code owner July 2, 2024 08:26
@TrySound TrySound requested review from dipikabh and removed request for a team July 2, 2024 08:26
@github-actions github-actions bot added Content:CSS Cascading Style Sheets docs size/s [PR only] 6-50 LoC changed labels Jul 2, 2024
Copy link
Contributor

github-actions bot commented Jul 6, 2024

Preview URLs

(comment last updated: 2024-07-07 13:15:52)

@Josh-Cena
Copy link
Member

See #34559 (comment) and #34563 (review) for examples of how we usually handle this

@TrySound TrySound changed the title fix(css): remove 'auto' value from outline-color fix(css): mention 'auto' value in outline-color as unsupported in any browser Jul 7, 2024
@TrySound
Copy link
Contributor Author

TrySound commented Jul 7, 2024

@Josh-Cena Improved similar to pr you mentioned. Is it good now?

Copy link
Member

@estelle estelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you.

@estelle estelle merged commit d962300 into mdn:main Jul 10, 2024
8 checks passed
evelinabe pushed a commit to evelinabe/mdn-content that referenced this pull request Jul 12, 2024
… browser (mdn#34551)

* fix(css): remove 'auto' value from outline-color

Reverts mdn#29798

See mdn/browser-compat-data#23538 (comment)

outline-color is not supported in any browser though [mdn](https://developer.mozilla.org/en-US/docs/Web/CSS/outline-color)
does not show it in compatibility table making an impression it is well
supported.

* Mention auto as unsupported keyword
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:CSS Cascading Style Sheets docs size/s [PR only] 6-50 LoC changed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants