Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(css): correct grid span usage #34695

Merged
merged 3 commits into from
Jul 9, 2024
Merged

fix(css): correct grid span usage #34695

merged 3 commits into from
Jul 9, 2024

Conversation

OnkarRuikar
Copy link
Contributor

The following two statements describe the same thing about using span keyword:
a. specify a start line and then the number of tracks you would like the grid area to span
b. specify a start line and N lines from the start line where the grid area ends

Both statements are the same because span 3 means 3 tracks and 1+3 lines. N tracks = 1 + N lines.

The specification defines span in terms of tracks. Using track is easier to explain in this context.

@OnkarRuikar OnkarRuikar requested a review from a team as a code owner July 8, 2024 07:56
@OnkarRuikar OnkarRuikar requested review from estelle and removed request for a team July 8, 2024 07:56
@github-actions github-actions bot added Content:CSS Cascading Style Sheets docs size/xs [PR only] 0-5 LoC changed labels Jul 8, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 8, 2024 •
edited
Loading

Preview URLs

(comment last updated: 2024-07-09 22:39:21)

estelle
estelle approved these changes Jul 9, 2024
View reviewed changes
Copy link
Member

@estelle estelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 🎉

@estelle estelle merged commit 98f55d2 into mdn:main Jul 9, 2024
8 checks passed
@OnkarRuikar OnkarRuikar deleted the patch-3 branch July 10, 2024 04:28
evelinabe pushed a commit to evelinabe/mdn-content that referenced this pull request Jul 12, 2024
@OnkarRuikar @estelle @evelinabe
fix(css): correct grid span usage (mdn#34695)
eb29bf9 
* fix(css): correct grid `span` usage

* small update

* Update files/en-us/web/css/css_grid_layout/grid_layout_using_line-based_placement/index.md

---------

Co-authored-by: Estelle Weyl <estelle@openwebdocs.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@estelle estelle estelle approved these changes

Assignees
No one assigned
Labels
Content:CSS Cascading Style Sheets docs size/xs [PR only] 0-5 LoC changed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Is span used to span tracks or lines?
2 participants
@OnkarRuikar @estelle