Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(CSS): clarify inline and block logical values with different writing modes #34729

Merged
merged 1 commit into from
Jul 10, 2024

Conversation

MJWade96
Copy link
Contributor

@MJWade96 MJWade96 commented Jul 9, 2024

The result of the final example given in the last paragraph under [Spanning explicit inline and block logical keywords] (https://developer.mozilla.org/en-US/docs/Web/CSS/inset-area_value#explicit_inline_and_block_logical_keywords ) is wrong

Description

Motivation

Additional details

Related issues and pull requests

The result of the final example given in the last paragraph under
[Spanning explicit inline and block logical keywords] 
(https://developer.mozilla.org/en-US/docs/Web/CSS/inset-area_value#explicit_inline_and_block_logical_keywords ) is wrong
@MJWade96 MJWade96 requested a review from a team as a code owner July 9, 2024 09:05
@MJWade96 MJWade96 requested review from bsmth and removed request for a team July 9, 2024 09:05
@github-actions github-actions bot added Content:CSS Cascading Style Sheets docs size/xs [PR only] 0-5 LoC changed labels Jul 9, 2024
Copy link
Contributor

Preview URLs

Flaws (1)

URL: /en-US/docs/Web/CSS/inset-area_value
Title: <inset-area>
Flaw count: 1

  • broken_links:
    • Can't resolve /en-US/docs/Web/CSS/inset-area_function

@bsmth bsmth requested review from chrisdavidmills and estelle and removed request for bsmth July 10, 2024 08:51
@bsmth
Copy link
Member

bsmth commented Jul 10, 2024

Thanks for raising this one. I had a quick look through and I'm not sure, so maybe Estelle or Chris have an idea. Is it worth clarifying what left-center etc. is relative to if writing mode changes?

@bsmth bsmth changed the title Update index.md fix(CSS): clarify inline and block logical values with different writing modes Jul 10, 2024
Copy link
Member

@estelle estelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. thank you!

@estelle estelle merged commit dd511c1 into mdn:main Jul 10, 2024
7 checks passed
evelinabe pushed a commit to evelinabe/mdn-content that referenced this pull request Jul 12, 2024
…ing modes (mdn#34729)

Update index.md

The result of the final example given in the last paragraph under
[Spanning explicit inline and block logical keywords] 
(https://developer.mozilla.org/en-US/docs/Web/CSS/inset-area_value#explicit_inline_and_block_logical_keywords ) is wrong
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:CSS Cascading Style Sheets docs size/xs [PR only] 0-5 LoC changed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants