-
Notifications
You must be signed in to change notification settings - Fork 22.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace alert in web api, scrollwidth property #34733
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Content:WebAPI
Web API docs
size/m
[PR only] 51-500 LoC changed
labels
Jul 9, 2024
Preview URLs (comment last updated: 2024-07-12 15:40:48) |
27 tasks
Josh-Cena
reviewed
Jul 11, 2024
github-actions
bot
added
size/m
[PR only] 51-500 LoC changed
and removed
Content:Media
Media docs
Content:MathML
MathML docs
Content:Glossary
Glossary entries
Content:Games
Games docs
Content:Learn:JavaScript
Learning area JavaScript docs
Content:Firefox
Content in the Mozilla/Firefox subtree
Content:Learn:CSS
Learning area CSS docs
Content:Manifest
system
[PR only] Infrastructure and configuration for the project
size/xl
[PR only] >1000 LoC changed
labels
Jul 12, 2024
Josh-Cena
reviewed
Jul 12, 2024
Josh-Cena
approved these changes
Jul 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Thanks a bunch!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
✍️ I have updated the example for the
scrollWidth
property. My intention was to only remove the alert function, but since the example code didn't follow the styling guides I grouped the code to code blocks and added some additional texts about the example as well.Motivation
❓ They get a working example for
scrollWidth
, and the code will be easier to read when it is grouped in code blocks.Additional details
🔗 #7566
Related issues and pull requests
See additional details