-
Notifications
You must be signed in to change notification settings - Fork 22.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added CSS marker-* properties #35107
Conversation
Preview URLs (7 pages)(comment last updated: 2024-08-12 21:35:15) |
This pull request has merge conflicts that must be resolved before it can be merged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not a reviewer but two suggestions based on my recent experience with CSS docs. The same applies to the other pages
Thanks, Eric. Everything looks good apart from the |
Pages should have structural macros even if they are broken in the interim period. This means we don't have to send another PR to add it back (or forget to do it at all) when mdn/data gets updated. The only problem is Yari doesn't generate a flaw for it, so we can't track effectively. |
Got it, there's a tracker in mdn/data to link back to these PRs so we don't forget |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple of suggestions to consider, but leaving a +1, thank you!
bsmth edit Co-authored-by: Brian Thomas Smith <brian@smith.berlin>
Committed your suggestion; thank YOU! |
Description
Adds pages for
marker-start
,marker-mid
,marker-end
, andmarker
properties, which recreate the effects of themarker-start
,marker-mid
, andmarker-end
SVG attributes, plus themarker
shorthand for the other three.Motivation
The page didn’t exist, and needed to be created (see #34763).