Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added CSS marker-* properties #35107

Merged
merged 10 commits into from
Aug 12, 2024
Merged

Added CSS marker-* properties #35107

merged 10 commits into from
Aug 12, 2024

Conversation

meyerweb
Copy link
Contributor

Description

Adds pages for marker-start, marker-mid, marker-end, and marker properties, which recreate the effects of the marker-start, marker-mid, and marker-end SVG attributes, plus the marker shorthand for the other three.

Motivation

The page didn’t exist, and needed to be created (see #34763).

@meyerweb meyerweb requested review from a team as code owners July 25, 2024 20:51
@meyerweb meyerweb requested review from bsmth and removed request for a team July 25, 2024 20:51
@github-actions github-actions bot added Content:CSS Cascading Style Sheets docs Content:SVG SVG docs size/m [PR only] 51-500 LoC changed labels Jul 25, 2024
@github-actions github-actions bot added the merge conflicts 🚧 [PR only] label Jul 25, 2024
Copy link
Contributor

This pull request has merge conflicts that must be resolved before it can be merged.

@github-actions github-actions bot removed the merge conflicts 🚧 [PR only] label Jul 26, 2024
Copy link
Member

@Josh-Cena Josh-Cena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a reviewer but two suggestions based on my recent experience with CSS docs. The same applies to the other pages

files/en-us/web/css/marker/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/marker/index.md Outdated Show resolved Hide resolved
@bsmth
Copy link
Member

bsmth commented Aug 1, 2024

Thanks, Eric. Everything looks good apart from the {{CSSInfo}} issues. Either we can remove them or add entries to mdn/data

@Josh-Cena
Copy link
Member

Either we can remove them

Pages should have structural macros even if they are broken in the interim period. This means we don't have to send another PR to add it back (or forget to do it at all) when mdn/data gets updated. The only problem is Yari doesn't generate a flaw for it, so we can't track effectively.

@bsmth
Copy link
Member

bsmth commented Aug 2, 2024

This means we don't have to send another PR to add it back (or forget to do it at all) when mdn/data gets updated. The only problem is Yari doesn't generate a flaw for it, so we can't track effectively.

Got it, there's a tracker in mdn/data to link back to these PRs so we don't forget

Copy link
Member

@bsmth bsmth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of suggestions to consider, but leaving a +1, thank you!

bsmth edit

Co-authored-by: Brian Thomas Smith <brian@smith.berlin>
@meyerweb
Copy link
Contributor Author

Couple of suggestions to consider, but leaving a +1, thank you!

Committed your suggestion; thank YOU!

@Josh-Cena Josh-Cena merged commit f1b6d2b into mdn:main Aug 12, 2024
8 checks passed
@meyerweb meyerweb deleted the markers branch August 13, 2024 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:CSS Cascading Style Sheets docs Content:SVG SVG docs size/m [PR only] 51-500 LoC changed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants