-
Notifications
You must be signed in to change notification settings - Fork 22.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(manifest): Improvements to shortcuts
page
#36034
Conversation
Preview URLs (comment last updated: 2024-10-08 17:51:03) |
Looks good! I've added some suggestions. I would be really great to see some screenshots, in particular if this behaviour is relatively stable and unlikely to change. |
e86e612
to
1b6c906
Compare
Thanks for reviewing, Hamish, some really great suggestions. I've made the updates and left comments if changes are slightly different from the suggestions. This is ready for another look. (I've added the screenshot idea to my list for doing something similar for icons and display pages.) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great. I merged a couple of minor "clear fixes". This one is for discussion https://github.com/mdn/content/pull/36034/files#r1791057357 - but I have approved so you can merge after looking at it.
Thanks, @hamishwillee, for helping get this across the finish line 🙌 |
Description
This work is part of improving the web/manifest docs.
Apart from normalizing the page layout to include "Syntax" and "Values", this PR includes the following changes:
Motivation
To ensure all sections have sufficient explanation, all caveats from spec are covered, and the pages follow a similar template
Additional details
Spec links:
Related issues and pull requests
Tracking issue: mdn/mdn#560