WebDriver conformance changes for Firefox 88 #4322

whimboo · 2021-04-20T18:50:39Z

Sorry for being late again with our changes but this is is what happened for WebDriver.

whimboo · 2021-04-20T18:51:03Z

CC @juliandescottes

github-actions · 2021-04-20T18:53:10Z

Preview URLs

https://pr4322.content.dev.mdn.mozit.cloud/en-US/docs/Mozilla/Firefox/Releases/88

Flaws

URL: /en-US/docs/Mozilla/Firefox/Releases/88
Title: Firefox 88 for developers
on GitHub
Flaw count: 1

macros:
- /en-US/docs/Web/CSS/:user-valid does not exist

External URLs

URL: /en-US/docs/Mozilla/Firefox/Releases/88
Title: Firefox 88 for developers
on GitHub

https://bugzilla.mozilla.org/show_bug.cgi?id=1342741 (1 time)
https://bugzilla.mozilla.org/show_bug.cgi?id=1519483 (1 time)
https://bugzilla.mozilla.org/show_bug.cgi?id=1593343 (1 time)
https://bugzilla.mozilla.org/show_bug.cgi?id=1626365 (1 time)
https://bugzilla.mozilla.org/show_bug.cgi?id=1664881 (1 time)
https://bugzilla.mozilla.org/show_bug.cgi?id=1680279 (1 time)
https://bugzilla.mozilla.org/show_bug.cgi?id=1686361 (1 time)
https://bugzilla.mozilla.org/show_bug.cgi?id=1691890 (1 time)
https://bugzilla.mozilla.org/show_bug.cgi?id=1693147 (1 time)
https://bugzilla.mozilla.org/show_bug.cgi?id=1693969 (1 time)
https://bugzilla.mozilla.org/show_bug.cgi?id=1694129 (1 time)
https://bugzilla.mozilla.org/show_bug.cgi?id=1694141 (1 time)
https://bugzilla.mozilla.org/show_bug.cgi?id=1694146 (1 time)
https://bugzilla.mozilla.org/show_bug.cgi?id=1694748 (1 time)
https://bugzilla.mozilla.org/show_bug.cgi?id=1695402 (1 time)
https://bugzilla.mozilla.org/show_bug.cgi?id=1695403 (1 time)
https://bugzilla.mozilla.org/show_bug.cgi?id=1696881 (1 time)
https://bugzilla.mozilla.org/show_bug.cgi?id=1697529 (1 time)
https://bugzilla.mozilla.org/show_bug.cgi?id=1698133 (1 time)
https://bugzilla.mozilla.org/show_bug.cgi?id=1698468 (1 time)
https://bugzilla.mozilla.org/show_bug.cgi?id=315209 (1 time)
https://hacks.mozilla.org/2021/04/never-too-late-for-firefox-88/ (1 time)

github-actions · 2021-04-20T18:53:53Z

Preview URLs

https://pr4322.content.dev.mdn.mozit.cloud/en-US/docs/Mozilla/Firefox/Releases/88

Flaws

URL: /en-US/docs/Mozilla/Firefox/Releases/88
Title: Firefox 88 for developers
on GitHub
Flaw count: 1

macros:
- /en-US/docs/Web/CSS/:user-valid does not exist

External URLs

URL: /en-US/docs/Mozilla/Firefox/Releases/88
Title: Firefox 88 for developers
on GitHub

https://bugzilla.mozilla.org/show_bug.cgi?id=1342741 (1 time)
https://bugzilla.mozilla.org/show_bug.cgi?id=1519483 (1 time)
https://bugzilla.mozilla.org/show_bug.cgi?id=1593343 (1 time)
https://bugzilla.mozilla.org/show_bug.cgi?id=1626365 (1 time)
https://bugzilla.mozilla.org/show_bug.cgi?id=1664881 (1 time)
https://bugzilla.mozilla.org/show_bug.cgi?id=1680279 (1 time)
https://bugzilla.mozilla.org/show_bug.cgi?id=1686361 (1 time)
https://bugzilla.mozilla.org/show_bug.cgi?id=1691890 (1 time)
https://bugzilla.mozilla.org/show_bug.cgi?id=1693147 (1 time)
https://bugzilla.mozilla.org/show_bug.cgi?id=1693969 (1 time)
https://bugzilla.mozilla.org/show_bug.cgi?id=1694129 (1 time)
https://bugzilla.mozilla.org/show_bug.cgi?id=1694141 (1 time)
https://bugzilla.mozilla.org/show_bug.cgi?id=1694146 (1 time)
https://bugzilla.mozilla.org/show_bug.cgi?id=1694748 (1 time)
https://bugzilla.mozilla.org/show_bug.cgi?id=1695402 (1 time)
https://bugzilla.mozilla.org/show_bug.cgi?id=1695403 (1 time)
https://bugzilla.mozilla.org/show_bug.cgi?id=1696881 (1 time)
https://bugzilla.mozilla.org/show_bug.cgi?id=1697529 (1 time)
https://bugzilla.mozilla.org/show_bug.cgi?id=1698133 (1 time)
https://bugzilla.mozilla.org/show_bug.cgi?id=1698468 (1 time)
https://bugzilla.mozilla.org/show_bug.cgi?id=315209 (1 time)
https://hacks.mozilla.org/2021/04/never-too-late-for-firefox-88/ (1 time)

juliandescottes

Content looks good to me, thanks! Small typos, but I think @chrisdavidmills will review that better than I can :)

files/en-us/mozilla/firefox/releases/88/index.html

chrisdavidmills

Couple of small change requests, but nothing major. Nice work @whimboo !

files/en-us/mozilla/firefox/releases/88/index.html

Co-authored-by: Julian Descottes <julian.descottes@gmail.com>

github-actions · 2021-04-21T16:20:18Z

Preview URLs

https://pr4322.content.dev.mdn.mozit.cloud/en-US/docs/Mozilla/Firefox/Releases/88

Flaws

URL: /en-US/docs/Mozilla/Firefox/Releases/88
Title: Firefox 88 for developers
on GitHub
Flaw count: 1

macros:
- /en-US/docs/Web/CSS/:user-valid does not exist

External URLs

URL: /en-US/docs/Mozilla/Firefox/Releases/88
Title: Firefox 88 for developers
on GitHub

https://bugzilla.mozilla.org/show_bug.cgi?id=1342741 (1 time)
https://bugzilla.mozilla.org/show_bug.cgi?id=1519483 (1 time)
https://bugzilla.mozilla.org/show_bug.cgi?id=1593343 (1 time)
https://bugzilla.mozilla.org/show_bug.cgi?id=1626365 (1 time)
https://bugzilla.mozilla.org/show_bug.cgi?id=1664881 (1 time)
https://bugzilla.mozilla.org/show_bug.cgi?id=1680279 (1 time)
https://bugzilla.mozilla.org/show_bug.cgi?id=1686361 (1 time)
https://bugzilla.mozilla.org/show_bug.cgi?id=1691890 (1 time)
https://bugzilla.mozilla.org/show_bug.cgi?id=1693147 (1 time)
https://bugzilla.mozilla.org/show_bug.cgi?id=1693969 (1 time)
https://bugzilla.mozilla.org/show_bug.cgi?id=1694129 (1 time)
https://bugzilla.mozilla.org/show_bug.cgi?id=1694141 (1 time)
https://bugzilla.mozilla.org/show_bug.cgi?id=1694146 (1 time)
https://bugzilla.mozilla.org/show_bug.cgi?id=1694748 (1 time)
https://bugzilla.mozilla.org/show_bug.cgi?id=1695402 (1 time)
https://bugzilla.mozilla.org/show_bug.cgi?id=1695403 (1 time)
https://bugzilla.mozilla.org/show_bug.cgi?id=1696881 (1 time)
https://bugzilla.mozilla.org/show_bug.cgi?id=1697529 (1 time)
https://bugzilla.mozilla.org/show_bug.cgi?id=1698133 (1 time)
https://bugzilla.mozilla.org/show_bug.cgi?id=1698468 (1 time)
https://bugzilla.mozilla.org/show_bug.cgi?id=315209 (1 time)
https://hacks.mozilla.org/2021/04/never-too-late-for-firefox-88/ (1 time)

github-actions · 2021-04-21T16:20:20Z

Preview URLs

https://pr4322.content.dev.mdn.mozit.cloud/en-US/docs/Mozilla/Firefox/Releases/88

Flaws

URL: /en-US/docs/Mozilla/Firefox/Releases/88
Title: Firefox 88 for developers
on GitHub
Flaw count: 1

macros:
- /en-US/docs/Web/CSS/:user-valid does not exist

External URLs

URL: /en-US/docs/Mozilla/Firefox/Releases/88
Title: Firefox 88 for developers
on GitHub

https://bugzilla.mozilla.org/show_bug.cgi?id=1342741 (1 time)
https://bugzilla.mozilla.org/show_bug.cgi?id=1519483 (1 time)
https://bugzilla.mozilla.org/show_bug.cgi?id=1593343 (1 time)
https://bugzilla.mozilla.org/show_bug.cgi?id=1626365 (1 time)
https://bugzilla.mozilla.org/show_bug.cgi?id=1664881 (1 time)
https://bugzilla.mozilla.org/show_bug.cgi?id=1680279 (1 time)
https://bugzilla.mozilla.org/show_bug.cgi?id=1686361 (1 time)
https://bugzilla.mozilla.org/show_bug.cgi?id=1691890 (1 time)
https://bugzilla.mozilla.org/show_bug.cgi?id=1693147 (1 time)
https://bugzilla.mozilla.org/show_bug.cgi?id=1693969 (1 time)
https://bugzilla.mozilla.org/show_bug.cgi?id=1694129 (1 time)
https://bugzilla.mozilla.org/show_bug.cgi?id=1694141 (1 time)
https://bugzilla.mozilla.org/show_bug.cgi?id=1694146 (1 time)
https://bugzilla.mozilla.org/show_bug.cgi?id=1694748 (1 time)
https://bugzilla.mozilla.org/show_bug.cgi?id=1695402 (1 time)
https://bugzilla.mozilla.org/show_bug.cgi?id=1695403 (1 time)
https://bugzilla.mozilla.org/show_bug.cgi?id=1696881 (1 time)
https://bugzilla.mozilla.org/show_bug.cgi?id=1697529 (1 time)
https://bugzilla.mozilla.org/show_bug.cgi?id=1698133 (1 time)
https://bugzilla.mozilla.org/show_bug.cgi?id=1698468 (1 time)
https://bugzilla.mozilla.org/show_bug.cgi?id=315209 (1 time)
https://hacks.mozilla.org/2021/04/never-too-late-for-firefox-88/ (1 time)

whimboo · 2021-04-21T16:22:52Z

@chrisdavidmills please check again. I just pushed the required changes.

github-actions · 2021-04-21T16:24:32Z

Preview URLs

https://pr4322.content.dev.mdn.mozit.cloud/en-US/docs/Mozilla/Firefox/Releases/88

Flaws

URL: /en-US/docs/Mozilla/Firefox/Releases/88
Title: Firefox 88 for developers
on GitHub
Flaw count: 1

macros:
- /en-US/docs/Web/CSS/:user-valid does not exist

External URLs

URL: /en-US/docs/Mozilla/Firefox/Releases/88
Title: Firefox 88 for developers
on GitHub

https://bugzilla.mozilla.org/show_bug.cgi?id=1342741 (1 time)
https://bugzilla.mozilla.org/show_bug.cgi?id=1519483 (1 time)
https://bugzilla.mozilla.org/show_bug.cgi?id=1593343 (1 time)
https://bugzilla.mozilla.org/show_bug.cgi?id=1626365 (1 time)
https://bugzilla.mozilla.org/show_bug.cgi?id=1664881 (1 time)
https://bugzilla.mozilla.org/show_bug.cgi?id=1680279 (1 time)
https://bugzilla.mozilla.org/show_bug.cgi?id=1686361 (1 time)
https://bugzilla.mozilla.org/show_bug.cgi?id=1691890 (1 time)
https://bugzilla.mozilla.org/show_bug.cgi?id=1693147 (1 time)
https://bugzilla.mozilla.org/show_bug.cgi?id=1693969 (1 time)
https://bugzilla.mozilla.org/show_bug.cgi?id=1694129 (1 time)
https://bugzilla.mozilla.org/show_bug.cgi?id=1694141 (1 time)
https://bugzilla.mozilla.org/show_bug.cgi?id=1694146 (1 time)
https://bugzilla.mozilla.org/show_bug.cgi?id=1694748 (1 time)
https://bugzilla.mozilla.org/show_bug.cgi?id=1695402 (1 time)
https://bugzilla.mozilla.org/show_bug.cgi?id=1695403 (1 time)
https://bugzilla.mozilla.org/show_bug.cgi?id=1696881 (1 time)
https://bugzilla.mozilla.org/show_bug.cgi?id=1697529 (1 time)
https://bugzilla.mozilla.org/show_bug.cgi?id=1698133 (1 time)
https://bugzilla.mozilla.org/show_bug.cgi?id=1698468 (1 time)
https://bugzilla.mozilla.org/show_bug.cgi?id=315209 (1 time)
https://hacks.mozilla.org/2021/04/never-too-late-for-firefox-88/ (1 time)

chrisdavidmills

Perfect, thanks @whimboo !

WebDriver conformance changes for Firefox 88

2b81175

whimboo requested a review from a team as a code owner April 20, 2021 18:50

whimboo requested review from chrisdavidmills and removed request for a team April 20, 2021 18:50

Removed dot.

4cd52b1

juliandescottes reviewed Apr 20, 2021

View reviewed changes

files/en-us/mozilla/firefox/releases/88/index.html Outdated Show resolved Hide resolved

files/en-us/mozilla/firefox/releases/88/index.html Outdated Show resolved Hide resolved

chrisdavidmills requested changes Apr 21, 2021

View reviewed changes

files/en-us/mozilla/firefox/releases/88/index.html Outdated Show resolved Hide resolved

files/en-us/mozilla/firefox/releases/88/index.html Outdated Show resolved Hide resolved

whimboo and others added 3 commits April 21, 2021 18:17

Update files/en-us/mozilla/firefox/releases/88/index.html

9bd70ac

Co-authored-by: Julian Descottes <julian.descottes@gmail.com>

Update files/en-us/mozilla/firefox/releases/88/index.html

c3f1633

Co-authored-by: Julian Descottes <julian.descottes@gmail.com>

fixed review comments.

40b594c

chrisdavidmills approved these changes Apr 21, 2021

View reviewed changes

chrisdavidmills merged commit 27e6a7e into mdn:main Apr 21, 2021

whimboo deleted the firefox_88 branch April 21, 2021 16:40

github-actions bot locked as resolved and limited conversation to collaborators Aug 15, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

WebDriver conformance changes for Firefox 88 #4322

WebDriver conformance changes for Firefox 88 #4322

whimboo commented Apr 20, 2021

whimboo commented Apr 20, 2021

github-actions bot commented Apr 20, 2021

github-actions bot commented Apr 20, 2021

juliandescottes left a comment

chrisdavidmills left a comment

github-actions bot commented Apr 21, 2021

github-actions bot commented Apr 21, 2021

whimboo commented Apr 21, 2021

github-actions bot commented Apr 21, 2021

chrisdavidmills left a comment

WebDriver conformance changes for Firefox 88 #4322

WebDriver conformance changes for Firefox 88 #4322

Conversation

whimboo commented Apr 20, 2021

whimboo commented Apr 20, 2021

github-actions bot commented Apr 20, 2021

Preview URLs

Flaws

External URLs

github-actions bot commented Apr 20, 2021

Preview URLs

Flaws

External URLs

juliandescottes left a comment

Choose a reason for hiding this comment

chrisdavidmills left a comment

Choose a reason for hiding this comment

github-actions bot commented Apr 21, 2021

Preview URLs

Flaws

External URLs

github-actions bot commented Apr 21, 2021

Preview URLs

Flaws

External URLs

whimboo commented Apr 21, 2021

github-actions bot commented Apr 21, 2021

Preview URLs

Flaws

External URLs

chrisdavidmills left a comment

Choose a reason for hiding this comment