Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update grid auto placement example #143

Merged
merged 3 commits into from
Jul 13, 2023
Merged

Update grid auto placement example #143

merged 3 commits into from
Jul 13, 2023

Conversation

OnkarRuikar
Copy link
Contributor

@OnkarRuikar OnkarRuikar commented Jul 13, 2023 •
edited
Loading

Problem

There are no gaps in the grid without using dense algorithm. So removing the grid-auto-flow: dense line has no effect.

Solution

Interleaving big and small blocks is not helping here. Putting bigger blocks together creates noticeable amount of gaps.

@estelle estelle merged commit c782a30 into mdn:main Jul 13, 2023
@OnkarRuikar OnkarRuikar deleted the patch-1 branch July 14, 2023 01:47
This was referenced Jul 14, 2023
Closed
Closed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@estelle estelle estelle approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Example is not working as expected Content bug: Suggested change/example in CSS Grid docs doesn't work
3 participants
@OnkarRuikar @estelle @bsmth