Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Best practice value for alpha channel and better contrast/visibility #74

Merged
merged 3 commits into from
Jun 7, 2022

Conversation

glmvc
Copy link
Contributor

@glmvc glmvc commented May 6, 2022

setting the alpha value to "0.2" instead of ".2"
it's considered best practice and it's common in style guides like in google ones (https://google.github.io/styleguide/htmlcssguide.html#Leading_0s)

Note pr #15579 in mdn/content, where I changed the image accordingly.

@glmvc
Copy link
Contributor Author

glmvc commented May 7, 2022

Update: I also increased the value of the alpha channel from 0.2 to 0.6 for better visibility. Note issue #2054

@glmvc glmvc changed the title Update color.html - best practice value for alpha channel Best practice value for alpha channel and better contrast / visibility May 7, 2022
@glmvc glmvc changed the title Best practice value for alpha channel and better contrast / visibility Best practice value for alpha channel and better contrast/visibility May 7, 2022
@dipikabh dipikabh merged commit c313e4c into mdn:main Jun 7, 2022
@glmvc glmvc deleted the patch-1 branch June 8, 2022 17:53
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants