Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes to Microsoft-specific CSS per comments by @lahmatiy #191

Merged
merged 2 commits into from
Apr 4, 2018

Conversation

jameshkramer
Copy link
Contributor

@jameshkramer jameshkramer commented Mar 7, 2018

@lahmatiy, @Elchi3, @erikadoyle, this is a new PR for the Microsoft CSS. The prior PRs were #156, #176, and #177.

@wbamberg wbamberg mentioned this pull request Apr 3, 2018
@jameshkramer
Copy link
Contributor Author

@lahmatiy, @Elchi3 I'd like for this to be reviewed. Is there anything I can do to make that happen? The topics we are creating depend on the data (cc: @erikadoyle).

Thank you.

@lahmatiy
Copy link
Contributor

lahmatiy commented Apr 4, 2018

Not sure all issues are fixed, but fixed many. LGTM

@jameshkramer
Copy link
Contributor Author

Thank you, @lahmatiy (cc: @erikadoyle).

@erikadoyle
Copy link

Yes, thank you @lahmatiy for all your help with this!

Copy link
Contributor

@wbamberg wbamberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the review @lahmatiy , and for your work on this @jameshkramer . I've spot-checked this against your previous comments as well as I could, let's merge this.

@wbamberg wbamberg merged commit 390d3d9 into mdn:master Apr 4, 2018
@jameshkramer
Copy link
Contributor Author

Thank you, @wbamberg and @lahmatiy (cc: @erikadoyle)! - Jim

@jameshkramer jameshkramer deleted the MDN-Porting-3 branch April 9, 2018 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants