Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a syntax errors for @font-face #221

Merged
merged 1 commit into from
May 17, 2018
Merged

Fix a syntax errors for @font-face #221

merged 1 commit into from
May 17, 2018

Conversation

lahmatiy
Copy link
Contributor

@lahmatiy lahmatiy commented May 6, 2018

I'm working on a new syntax parser and validator in CSSTree. Now it parses a complicated syntaxes and I found an error in @font-face syntaxes.

Btw, syntaxes in css/at-rule.json have several issues (see #222)

@lahmatiy
Copy link
Contributor Author

@wbamberg Can we merge this PR? @font-face syntaxes can't be parsed without these changes.

@wbamberg
Copy link
Contributor

Yes, I'll have a look today. Hoping to make a release today as well, so if there are any other PRs you'd really like to see, let me know.

Copy link
Contributor

@wbamberg wbamberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @lahmatiy !

@wbamberg wbamberg merged commit 7ad1528 into mdn:master May 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants