Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update font-palette animation type #716

Merged
merged 1 commit into from
Feb 27, 2024

Conversation

chrisdavidmills
Copy link
Contributor

@chrisdavidmills chrisdavidmills commented Feb 26, 2024

Description

The animation type of font-palette recently changed from discrete to by computed value. This PR reflects this change in the data. See https://drafts.csswg.org/css-fonts/#font-palette-prop

Motivation

Additional details

Related issues and pull requests

@hamishwillee
Copy link
Contributor

@chrisdavidmills I'd merge this but the linked spec still indicates the type is discrete https://drafts.csswg.org/css-fonts/#font-palette-prop

@chrisdavidmills
Copy link
Contributor Author

@chrisdavidmills I'd merge this but the linked spec still indicates the type is discrete https://drafts.csswg.org/css-fonts/#font-palette-prop

@hamishwillee Um, I'm confused; it says Animation type: By computed value. Screenshot below.

Screenshot 2024-02-27 at 07 52 05

@hamishwillee
Copy link
Contributor

hamishwillee commented Feb 27, 2024

Wow - definitely said discrete for me this morning - that's why I copied the link. Unless I was looking at another property of course. Oh well.

@hamishwillee
Copy link
Contributor

But it turns out I don't have the magic reviewer power here anyway ....

@chrisdavidmills
Copy link
Contributor Author

Wow - definitely said discrete for me this morning - that's why I copied the link. Unless I was looking at another property of course. Oh well.

How bizarre ;-)

@bsmth bsmth merged commit cd8d5db into mdn:main Feb 27, 2024
4 checks passed
bsmth pushed a commit that referenced this pull request Feb 27, 2024
🤖 I have created a release *beep* *boop*
---


## [2.4.2](v2.4.1...v2.4.2)
(2024-02-27)


### Bug Fixes

* **css:** overflow-wrap applies to text elements
([#705](#705))
([6732de5](6732de5))
* Update font-palette animation type
([#716](#716))
([cd8d5db](cd8d5db))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants