-
Notifications
You must be signed in to change notification settings - Fork 192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(css): Add stroke CSS SVG properties #757
Conversation
Hooray, I finally managed to get it to lint! Ready for merge, I hope. |
Thanks, Eric! There's a couple of conflicts now, do you want to have a look? I've added myself as reviewer for when you're ready |
I think I resolved them — let me know if not, thanks! |
Addresses #750 |
Taking a look now 👀 |
"mdn_url": "https://developer.mozilla.org/docs/Web/CSS/stroke-linecap" | ||
}, | ||
"stroke-linejoin": { | ||
"syntax": "miter | miter-clip | round | bevel | arcs", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In https://www.w3.org/TR/fill-stroke-3/#stroke-linejoin, it has the following:
"syntax": "miter | miter-clip | round | bevel | arcs", | |
"syntax": "[ crop | arcs | miter ] || [ bevel | round | stupid ]", |
Am I looking at the right spec?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The MDN page references https://drafts.fxtf.org/fill-stroke-3/#stroke-linejoin
which has the following syntax [ crop | arcs | miter ] || [ bevel | round | fallback ]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No browser supports this syntax, and all of them support the syntax I included. Is there a way to mark formal syntaxes that diverge from reality? Happy to use that if so.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's my understanding that we should be reflecting spec land in this repo and BCD will be where we have implementation data (reality) / granularity per value, but I'm going to get confirmation and get back with an answer shortly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey Eric, we discussed this, and as for mdn/data we always mirror spec syntax, but considering the circumstance with SVG definitions / CSS spec definitions, your additions are good for now so that we have formal definition values.
@bsmth I wrote some responses to your feedback on formal syntaxes; let me know how best to proceed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @meyerweb, I will merge shortly unless there's anything else outstanding, do you want to have a final check beforehand?
Nope, go for it! |
Description
Adds the properties
stroke
,stroke-dasharray
,stroke-dashoffset
,stroke-linecap
,stroke-linejoin
,stroke-miterlimit
,stroke-opacity
, andstroke-width
.Motivation
These properties are soon to be added to MDN reference content and need the formal syntax data to back them up.
Related issues and pull requests
Relates to mdn/content#34763.